Skip to content

riscv_dis_support_special_encodings_1

Jump to bottom
Tsukasa OI edited this page Jul 31, 2023 · 6 revisions

Disassembler: Support special (non-standard) encodings (widening FP ops)

Based On

Issue Solved

Some of the floating point instructions does not depend on the rounding mode despite the existence of rm (rounding mode) field. Such examples are widening conversion instructions.

Quoting "11.2 Floating-Point Control and Status Register" from the RISC-V ISA Manual (version 20191213):

Some instructions, including widening conversions, have the rm field but are nevertheless unaffected by the rounding mode; software should set their rm field to RNE (000).

The latest draft of the ISA Manual is clarified further:

Quoting "13.2 Floating-Point Control and Status Register" from the RISC-V ISA Manual (version draft-20221119-5234c63):

Some instructions, including widening conversions, have the rm field but are nevertheless mathematically unaffected by the rounding mode; software should set their rm field to RNE (000) but implementations must treat the rm field as usual (in particular, with regard to decoding legal vs. reserved encodings).

For instance, to encode a FCVT.D.S instruction, we should set its rm field to RNE (0b000). However, FCVT.D.S instruction with non-RNE rm field is still a valid instruction (despite that GAS does not allow specifying any rounding modes on FCVT.D.S) and must handle as a valid instruction when disassembled unless an invalid rounding mode is specified.

However, current GNU Binutils only supports disassembling widening conversion instructions with rm field of RNE (0b000) except FCVT.Q.L and FCVT.Q.LU instructions (two instructions supported specifying rounding modes for historical reasons).

This patchset (in specific, the commit "RISC-V: Rounding mode on widening instructions") enables special handling of such instructions by adding two new operand types:

  1. "WfM":
    Optional rounding mode where specifying rounding mode is not supported in the past.
  2. "Wfm":
    Optional rounding mode where specifying rounding mode is supported in the past (used in FCVT.Q.L and FCVT.Q.LU).

I designed this patchset to be configurable (allow implementing S Pawan Kumar's proposal if needed) but the behavior in this patchset is as follows:

On the disassembler, optional (non-RNE [≠ 0b000]) rounding mode is printed only if:

  1. "no-aliases" disassembler option is specified, or
  2. the rounding mode is invalid (0b101 / 0b110).

I think removing condition (1) might be an option. Because, despite that we can now see the actual rounding mode with condition (1), it's not valid as an assembler mnemonic.

Condition (2) is an intentional choice to detect invalid encodings. Still, it could be removed, too (I don't recommend though).

On the assembler, specifying optional rounding mode is prohibited (except FCVT.Q.L and FCVT.Q.LU) or accepted with a warning (FCVT.Q.L and FCVT.Q.LU).

Disassembler Dumps

Before this patchset: objdump -d (with my comment)

8000002c:       42058553                fcvt.d.s        fa0,fa1
80000030:       42059553                .4byte          0x42059553  # Valid (but not recommended) encoding of FCVT.D.S
80000034:       4205a553                .4byte          0x4205a553  # Valid (but not recommended) encoding of FCVT.D.S
80000038:       4205b553                .4byte          0x4205b553  # Valid (but not recommended) encoding of FCVT.D.S
8000003c:       4205c553                .4byte          0x4205c553  # Valid (but not recommended) encoding of FCVT.D.S
80000040:       4205f553                .4byte          0x4205f553  # Valid (but not recommended) encoding of FCVT.D.S
80000044:       4205d553                .4byte          0x4205d553  # Invalid FCVT.D.S (reserved rounding mode 0b101)
80000048:       4205e553                .4byte          0x4205e553  # Invalid FCVT.D.S (reserved rounding mode 0b110)

After this patchset: objdump -d 

8000002c:       42058553                fcvt.d.s        fa0,fa1
80000030:       42059553                fcvt.d.s        fa0,fa1
80000034:       4205a553                fcvt.d.s        fa0,fa1
80000038:       4205b553                fcvt.d.s        fa0,fa1
8000003c:       4205c553                fcvt.d.s        fa0,fa1
80000040:       4205f553                fcvt.d.s        fa0,fa1
80000044:       4205d553                fcvt.d.s        fa0,fa1,unknown
80000048:       4205e553                fcvt.d.s        fa0,fa1,unknown

After this patchset: objdump -M no-aliases -d 

8000002c:       42058553                fcvt.d.s        fa0,fa1
80000030:       42059553                fcvt.d.s        fa0,fa1,rtz
80000034:       4205a553                fcvt.d.s        fa0,fa1,rdn
80000038:       4205b553                fcvt.d.s        fa0,fa1,rup
8000003c:       4205c553                fcvt.d.s        fa0,fa1,rmm
80000040:       4205f553                fcvt.d.s        fa0,fa1,dyn
80000044:       4205d553                fcvt.d.s        fa0,fa1,unknown
80000048:       4205e553                fcvt.d.s        fa0,fa1,unknown
Clone this wiki locally