fix(goal_planner): use precise distance to objects for sorting candidate paths #10296
+144
−47
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 24, 2025 in 36s
CodeScene PR Check
Quality Gate Failed
(1 files improve in Code Health)
Gates Failed
(1 hotspot with Complex Method)
(1 file with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Prevent hotspot decline | Violations | Code Health Impact | |
|---|---|---|---|
| goal_planner_module.cpp | 1 rule in this hotspot | 3.30 → 3.28 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| goal_planner_module.cpp | 1 advisory rule | 3.30 → 3.28 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| util.cpp | 6.67 → 6.83 | Complex Method, Overall Code Complexity |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method goal_planner_module.cpp: sortPullOverPaths 🔥
✅ Improving Code Health:
- Overall Code Complexity util.cpp
- Complex Method util.cpp: checkObjectsCollision
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
sortPullOverPaths increases in cyclomatic complexity from 18 to 22, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
checkObjectsCollision is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.41 to 4.34, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading