fix(obstacle stop/slow_down): early return without point cloud #10289
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Mar 17, 2025 in 46s
CodeScene PR Check
Quality Gate Passed
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| obstacle_slow_down_module.cpp | no change | Overall Code Complexity |
| obstacle_stop_module.cpp | 6.57 → 6.67 | Lines of Code in a Single File, Bumpy Road Ahead, Overall Code Complexity |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
✅ Improving Code Health:
- Overall Code Complexity obstacle_slow_down_module.cpp
- Lines of Code in a Single File obstacle_stop_module.cpp
- Overall Code Complexity obstacle_stop_module.cpp
- Bumpy Road Ahead obstacle_stop_module.cpp: ObstacleStopModule::filter_stop_obstacle_for_point_cloud
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.35 to 5.26, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1053 to 1048, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
ObstacleStopModule::filter_stop_obstacle_for_point_cloud is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.26 to 4.20, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading