-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(obstacle stop/slow_down): early return without point cloud #10289
fix(obstacle stop/slow_down): early return without point cloud #10289
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
obstacle_filtering_param_ = ObstacleFilteringParam(node); | ||
use_pointcloud_ = | ||
get_or_declare_parameter<bool>(node, "obstacle_stop.obstacle_filtering.object_type.pointcloud"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The parameter was duplicated.
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10289 +/- ##
==========================================
- Coverage 26.04% 26.04% -0.01%
==========================================
Files 1375 1375
Lines 106439 106465 +26
Branches 40902 40901 -1
==========================================
Hits 27726 27726
- Misses 76009 76035 +26
Partials 2704 2704
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The obstacle_stop and obstacle_slow_down modules without point cloud were very heavy since the point cloud processing was not skipped.
This PR returns early without the point cloud processing when the point cloud is disabled.
TODO: With another PR, the heavy calculation of the point cloud processing should be handled.
before:
after:
Related links
How was this PR tested?
psim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.