Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOCOMMIT: PoC: vectorize just expm1 #9586

Draft
wants to merge 2 commits into
base: gh/swolchok/396/head
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 25, 2025

Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the unary_ufunc_* ops.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9586

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit 6c7c0e6 with merge base 644b7dd (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops.

ghstack-source-id: 94797d60df66089ebda3321a525d8a707be830f2
ghstack-comment-id: 2751961712
Pull Request resolved: #9586
@swolchok swolchok marked this pull request as draft March 25, 2025 17:06
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2025
swolchok added a commit that referenced this pull request Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops.

ghstack-source-id: 94797d60df66089ebda3321a525d8a707be830f2
ghstack-comment-id: 2751961712
Pull Request resolved: #9586
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops.

ghstack-source-id: e65c2b075587f716b8a746616d3335bab69a261d
ghstack-comment-id: 2751961712
Pull Request resolved: #9586
swolchok added a commit to swolchok/ghstack that referenced this pull request Mar 25, 2025
I ran into an issue reordering diffs in a direct stack (the one currently ending in pytorch/executorch#9586) where GitHub's API complained `There are no new commits between base branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`. This seems to have fixed it for me.
swolchok added a commit to swolchok/ghstack that referenced this pull request Mar 27, 2025
I ran into an issue reordering diffs in a direct stack (the one currently ending in pytorch/executorch#9586) where GitHub's API complained `There are no new commits between base branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`. This seems to have fixed it for me.
ezyang pushed a commit to ezyang/ghstack that referenced this pull request Mar 28, 2025
I ran into an issue reordering diffs in a direct stack (the one
currently ending in pytorch/executorch#9586)
where GitHub's API complained `There are no new commits between base
branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`.
This seems to have fixed it for me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants