-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOCOMMIT: PoC: vectorize just expm1 #9586
Draft
swolchok
wants to merge
2
commits into
gh/swolchok/396/head
Choose a base branch
from
gh/swolchok/397/head
base: gh/swolchok/396/head
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9586
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled JobAs of commit 6c7c0e6 with merge base 644b7dd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 25, 2025
Open
swolchok
added a commit
that referenced
this pull request
Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops. ghstack-source-id: 94797d60df66089ebda3321a525d8a707be830f2 ghstack-comment-id: 2751961712 Pull Request resolved: #9586
swolchok
added a commit
that referenced
this pull request
Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops. ghstack-source-id: 94797d60df66089ebda3321a525d8a707be830f2 ghstack-comment-id: 2751961712 Pull Request resolved: #9586
swolchok
added a commit
that referenced
this pull request
Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops. ghstack-source-id: e65c2b075587f716b8a746616d3335bab69a261d ghstack-comment-id: 2751961712 Pull Request resolved: #9586
swolchok
added a commit
to swolchok/ghstack
that referenced
this pull request
Mar 25, 2025
I ran into an issue reordering diffs in a direct stack (the one currently ending in pytorch/executorch#9586) where GitHub's API complained `There are no new commits between base branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`. This seems to have fixed it for me.
swolchok
added a commit
to swolchok/ghstack
that referenced
this pull request
Mar 27, 2025
I ran into an issue reordering diffs in a direct stack (the one currently ending in pytorch/executorch#9586) where GitHub's API complained `There are no new commits between base branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`. This seems to have fixed it for me.
ezyang
pushed a commit
to ezyang/ghstack
that referenced
this pull request
Mar 28, 2025
I ran into an issue reordering diffs in a direct stack (the one currently ending in pytorch/executorch#9586) where GitHub's API complained `There are no new commits between base branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`. This seems to have fixed it for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is how we can vectorize
expm1
given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all theunary_ufunc_*
ops.