relax tolerances for all unary float ops #9585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9585
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 61b2a26 with merge base c43d5ad ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 25, 2025
Open
facebook-github-bot
added
the
CLA Signed
swolchok
changed the base branch from
gh/swolchok/395/head
to
gh/swolchok/386/head
swolchok
added a commit
that referenced
this pull request
Mar 26, 2025
We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to float by default, not double. Use the ATen tolerances everywhere ghstack-source-id: 527e327ac1fa9f0387cbeb88ed9c27fe81642fbd ghstack-comment-id: 2751961338 Pull Request resolved: #9585
swolchok
added a commit
that referenced
this pull request
Mar 26, 2025
We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to float by default, not double. Use the ATen tolerances everywhere ghstack-source-id: dd22db8e7a145d8ec378757a4699b9195f1945f6 ghstack-comment-id: 2751961338 Pull Request resolved: #9585
swolchok
added a commit
that referenced
this pull request
Mar 26, 2025
We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to float by default, not double. Use the ATen tolerances everywhere ghstack-source-id: aee3ae32901abb9849c9ed78c5134fde0226b663 ghstack-comment-id: 2751961338 Pull Request resolved: #9585
swolchok
added a commit
that referenced
this pull request
Mar 26, 2025
We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to float by default, not double. Use the ATen tolerances everywhere ghstack-source-id: 616326b8931d4b0193a3389b001b4b5afd29be12 ghstack-comment-id: 2751961338 Pull Request resolved: #9585
manuelcandales
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to
floatby default, notdouble. Use the ATen tolerances everywhere.