Add SupportedTensorDtypes::{BOOL,REALH} #9584
Open
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
requested review from
JacobSzwejbka,
lucylq,
manuelcandales,
shoumikhin,
jackzhxng,
iseeyuan,
larryliu0820,
tarun292,
kirklandsign,
cccclai,
digantdesai,
metascroy,
mergennachin,
Gasoonjia,
mcr229,
SS-JIA and
kimishpatel
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9584
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit f934bc0 with merge base 644b7dd ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 25, 2025
swolchok
removed request for
digantdesai,
shoumikhin,
mergennachin,
SS-JIA,
larryliu0820,
iseeyuan,
GregoryComer,
cccclai,
lucylq,
JacobSzwejbka,
Gasoonjia,
jackzhxng,
mcr229,
tarun292,
kirklandsign and
metascroy
| @@ -23,10 +23,14 @@ bool check_tensor_dtype( | |||
| return executorch::runtime::tensor_is_realhbbf16_type(t); | |||
| case SupportedTensorDtypes::REALHBF16: | |||
| return executorch::runtime::tensor_is_realhbf16_type(t); | |||
| case SupportedTensorDtypes::REALH: | |||
There was a problem hiding this comment.
what is the h in realh? half?
There was a problem hiding this comment.
yes, it matches the naming scheme in
JacobSzwejbka
approved these changes
Mar 25, 2025
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
swolchok
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
swolchok
changed the base branch from
gh/swolchok/386/head
to
gh/swolchok/382/head
|
probably we want to skip adding REALH and just replace it with REALHBF16 in subseqeuent diffs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of REALH will be to support the current use cases of unary_ufunc_realh. (Maybe we should just change them to support BF16?)