BroadcastIndexesRange: leading 1s don't require true broadcasting #9431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
requested review from
manuelcandales,
tarun292,
cccclai,
metascroy,
cymbalrush,
mergennachin,
GregoryComer,
kirklandsign,
SS-JIA,
digantdesai and
shoumikhin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9431
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7c23fec with merge base 65ebabb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 20, 2025
Open
swolchok
removed request for
digantdesai,
shoumikhin,
cymbalrush,
mergennachin,
SS-JIA,
GregoryComer and
cccclai
swolchok
added a commit
that referenced
this pull request
Mar 28, 2025
Moved the mechanism we use to detect broadcasting from optimized/util/binary_ops.h ghstack-source-id: 53267b175e56c47877ab216a18b8d2ceef5a9c84 ghstack-comment-id: 2738665656 Pull Request resolved: #9431
This was referenced Mar 28, 2025
swolchok
changed the base branch from
gh/swolchok/383/head
to
gh/swolchok/407/head
swolchok
added a commit
that referenced
this pull request
Mar 28, 2025
Moved the mechanism we use to detect broadcasting from optimized/util/binary_ops.h ghstack-source-id: e21213f88de75cd198fb5d34f30c9c44e9e54d52 ghstack-comment-id: 2738665656 Pull Request resolved: #9431
manuelcandales
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the mechanism we use to detect broadcasting from optimized/util/binary_ops.h