docs: Fix tracing grpc example #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 123 123
Lines 22670 22670
=====================================
Hits 17986 17986
Misses 4684 4684 ☔ View full report in Codecov by Sentry. |
cijothomas
commented
Feb 26, 2025
| @@ -58,16 +62,23 @@ async fn greet() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static | |||
|
|
|||
| let response = client.say_hello(request).await; | |||
|
|
|||
| let span = cx.span(); | |||
There was a problem hiding this comment.
trying to get the span from context once, and re-use. Seeing the benchmarks for Context, I suspect asking for current span from Context repeatedly is unnecessarily burning CPU cycles.
4 tasks
lalitb
reviewed
Feb 26, 2025
lalitb
approved these changes
Feb 26, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example was not building as required features were not enabled.
Also modified provider to use SimpleExporter, consistent with rest of examples to immediately see spans printed to console.
changed port from 50051 to 50052, as 50051 is what most tutorials showcase and hence likely to clash port.
Nit additions to span attributes. Eventually we need this to match the OTel conventions, but not this PR.