-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Try to build examples in CI #2711
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2711 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 123 123
Lines 22670 22670
=====================================
Hits 17986 17986
Misses 4684 4684 ☔ View full report in Codecov by Sentry. |
#2710 will fix the example! |
Oops. Build succeeded! |
Yeah that's strange. Ideally scripts/test.sh should build the example directory too, as it is part of workspace. |
cargo test --workspace --all-features --lib This won't build examples as they are not "lib"... But still unclear how building it from root is working for me, but building from project directory is failing |
@scottgerring - How about making ":" also mandatory :) |
TBH I don't know that it isn't - but i'll check now. I don't remember doing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming we're happy with the examples only building on Linux.
(I think we should be)
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes