Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Try to build examples in CI #2711

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cijothomas
Copy link
Member

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team as a code owner February 26, 2025 07:18
@cijothomas cijothomas changed the title CI Try to build examples in CI ci Try to build examples in CI Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (edb0d58) to head (e3a005b).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2711   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        123     123           
  Lines      22670   22670           
=====================================
  Hits       17986   17986           
  Misses      4684    4684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member Author

#2710 will fix the example!

@cijothomas
Copy link
Member Author

Oops. Build succeeded!

@scottgerring scottgerring changed the title ci Try to build examples in CI ci: Try to build examples in CI Feb 26, 2025
@lalitb
Copy link
Member

lalitb commented Feb 26, 2025

Yeah that's strange. Ideally scripts/test.sh should build the example directory too, as it is part of workspace.

@cijothomas
Copy link
Member Author

Yeah that's strange. Ideally scripts/test.sh should build the example directory too, as it is part of workspace.

cargo test --workspace --all-features --lib

This won't build examples as they are not "lib"... But still unclear how building it from root is working for me, but building from project directory is failing

@lalitb
Copy link
Member

lalitb commented Feb 26, 2025

image

@scottgerring - How about making ":" also mandatory :)

@scottgerring
Copy link
Contributor

scottgerring commented Mar 6, 2025

@scottgerring - How about making ":" also mandatory :)

TBH I don't know that it isn't - but i'll check now. I don't remember doing this!
edit - the : is already mandatory

@scottgerring scottgerring changed the title ci: Try to build examples in CI ci Try to build examples in CI Mar 6, 2025
@scottgerring scottgerring changed the title ci Try to build examples in CI ci: Try to build examples in CI Mar 6, 2025
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we're happy with the examples only building on Linux.
(I think we should be)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants