chore: tonic with no default deps #2721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 123 123
Lines 22670 22670
=====================================
Hits 17986 17986
Misses 4684 4684 ☔ View full report in Codecov by Sentry. |
|
but in router = ["dep:axum", "dep:tower", "tower?/util"]
server = [
"router",
"dep:h2",
"dep:hyper", "hyper?/server",
"dep:hyper-util", "hyper-util?/service", "hyper-util?/server-auto",
"dep:socket2",
"dep:tokio", "tokio?/macros", "tokio?/net", "tokio?/time",
"tokio-stream/net",
"dep:tower", "tower?/util", "tower?/limit",
]so using of server leads to so fix is only partial in here |
lalitb
reviewed
Feb 26, 2025
examples/tracing-grpc/Cargo.toml
Outdated
| @@ -19,7 +19,7 @@ opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["rt-tokio"] | |||
| opentelemetry-stdout = { workspace = true, features = ["trace"] } | |||
| prost = { workspace = true } | |||
| tokio = { workspace = true, features = ["full"] } | |||
| tonic = { workspace = true, features = ["server"] } | |||
| tonic = { workspace = true, default-features = false, features = ["server"] } | |||
There was a problem hiding this comment.
nit - this would conflict with #2710 based on whichever is merged first.
There was a problem hiding this comment.
commented, may be these can be made in sync. "server" seems conflicts on deeper "tonic" level and not fix possible without tonic patch.
lalitb
approved these changes
Feb 26, 2025
cijothomas
reviewed
Feb 26, 2025
opentelemetry-otlp/Cargo.toml
Outdated
| @@ -34,7 +34,7 @@ opentelemetry-proto = { version = "0.28", path = "../opentelemetry-proto", defau | |||
| tracing = {workspace = true, optional = true} | |||
|
|
|||
| prost = { workspace = true, optional = true } | |||
| tonic = { workspace = true, optional = true } | |||
| tonic = { workspace = true, default-features = false, optional = true } | |||
There was a problem hiding this comment.
is it required to state defaut-features=false here, given it is already in the workspace?
|
i see was fixed in other pr, so closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2720
Changes
tonic with no default features excludes axum from cargo tree
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes