Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: when depend on tonic, use it with default-features = falseh #2720

Closed
dzmitry-lahoda opened this issue Feb 26, 2025 · 2 comments
Closed

Comments

@dzmitry-lahoda
Copy link

here:

tonic = { workspace = true, features = ["server"] }

because tonic defaults to routing feature depends on axum (full blown web framework).
which breaks my build.

in general ore libs should make all deps default-features = false by default

@cijothomas
Copy link
Member

in general ore libs should make all deps default-features = false by default

Agree 💯 Would you have some bandwidth to make this change?

@dzmitry-lahoda
Copy link
Author

likely solved by #2710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants