Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(predicted_path_checker): check if trajectory size #6730

Conversation

beyzanurkaya
Copy link
Contributor

Description

Fixes: #6728

Tests performed

ppc.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@beyzanurkaya beyzanurkaya requested a review from brkay54 as a code owner April 2, 2024 10:52
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Apr 2, 2024
@beyzanurkaya beyzanurkaya changed the title fix(predicted_path_checker): check if trajectory points are empty fix(predicted_path_checker): check if trajectory size Apr 2, 2024
@beyzanurkaya beyzanurkaya self-assigned this Apr 2, 2024
@beyzanurkaya beyzanurkaya added type:bug Software flaws or errors. run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Apr 2, 2024
Copy link
Member

@brkay54 brkay54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just I want to a minor change.
Could you move the trajectory size projection to beggining of the function because If the trajectory size is low, no need to process other operations.

And also could you add error print for trajectory size?

Signed-off-by: beyza <bnk@leodrive.ai>
@beyzanurkaya beyzanurkaya force-pushed the fix/predicted-path-checker-died branch from 18960f0 to fb278f5 Compare April 2, 2024 12:09
@beyzanurkaya
Copy link
Contributor Author

@brkay54 I made the necessary changes

@brkay54 brkay54 self-requested a review April 2, 2024 12:16
Copy link
Member

@brkay54 brkay54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@brkay54 brkay54 enabled auto-merge (squash) April 2, 2024 12:18
@brkay54 brkay54 merged commit 5617f74 into autowarefoundation:main Apr 2, 2024
20 of 22 checks passed
@beyzanurkaya beyzanurkaya deleted the fix/predicted-path-checker-died branch April 2, 2024 12:39
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Apr 5, 2024
…tion#6730)

check trajectory size

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…tion#6730)

check trajectory size

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:bug Software flaws or errors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

control_container dies because of the predicted_path_checker
2 participants