Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(predicted_path_checker): check if trajectory size #6730

Merged
merged 1 commit into from
Apr 2, 2024

check trajectory size

fb278f5
Select commit
Loading
Failed to load commit list.
Merged

fix(predicted_path_checker): check if trajectory size #6730

check trajectory size
fb278f5
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Apr 2, 2024 in 31s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method predicted_path_checker_node.cpp: PredictedPathCheckerNode::filterObstacles

Annotations

Check warning on line 543 in control/predicted_path_checker/src/predicted_path_checker_node/predicted_path_checker_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

PredictedPathCheckerNode::filterObstacles increases in cyclomatic complexity from 10 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis