Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): object size becomes zero, risk of numeric error and overflow on IoU calculation #6597

Merge branch 'main' into bugfix/tracker-object-size-zero-iou-overflow

c48e7d5
Select commit
Loading
Failed to load commit list.
Merged

fix(multi_object_tracker): object size becomes zero, risk of numeric error and overflow on IoU calculation #6597

Merge branch 'main' into bugfix/tracker-object-size-zero-iou-overflow
c48e7d5
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 12, 2024 in 37s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 4 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method big_vehicle_tracker.cpp: BigVehicleTracker::BigVehicleTracker
  • Large Method normal_vehicle_tracker.cpp: NormalVehicleTracker::NormalVehicleTracker
  • Large Method pedestrian_tracker.cpp: PedestrianTracker::PedestrianTracker
  • Large Method bicycle_tracker.cpp: BicycleTracker::BicycleTracker

Annotations

Check warning on line 147 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

BicycleTracker::BicycleTracker increases from 89 to 92 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 5.29 to 5.43, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 164 in perception/multi_object_tracker/src/tracker/model/big_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

BigVehicleTracker::BigVehicleTracker increases from 100 to 103 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 164 in perception/multi_object_tracker/src/tracker/model/normal_vehicle_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

NormalVehicleTracker::NormalVehicleTracker increases from 100 to 103 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 152 in perception/multi_object_tracker/src/tracker/model/pedestrian_tracker.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

PedestrianTracker::PedestrianTracker increases from 89 to 94 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.