feat(start_planner): move collision check to plan method #6564
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Mar 14, 2024 in 32s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method shift_pull_out.cpp: ShiftPullOut::plan
✅ Improving Code Health:
- Lines of Code in a Single File start_planner_module.cpp 🔥
Annotations
Check warning on line 120 in planning/behavior_path_start_planner_module/src/shift_pull_out.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
ShiftPullOut::plan increases in cyclomatic complexity from 9 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1369 to 1324, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Loading