fix(external_cmd_converter): define timer_rate parameter #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit introduces a missing launch argument "timer_rate" to the external_cmd_converter. This parameter is used to set the update rate of the timer. The default value for this parameter is 10.0. The changes have been reflected in both .py and .xml launch files. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
github-actions
bot
added
the
component:vehicle
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5719 +/- ##
==========================================
- Coverage 15.32% 0.00% -15.33%
==========================================
Files 1721 1 -1720
Lines 118559 111 -118448
Branches 37995 0 -37995
==========================================
- Hits 18169 0 -18169
+ Misses 79657 111 -79546
+ Partials 20733 0 -20733
☔ View full report in Codecov by Sentry. |
danielsanchezaran
pushed a commit
to tier4/autoware_universe
that referenced
this pull request
Dec 15, 2023
…ndation#5719) The commit introduces a missing launch argument "timer_rate" to the external_cmd_converter. This parameter is used to set the update rate of the timer. The default value for this parameter is 10.0. The changes have been reflected in both .py and .xml launch files. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The commit introduces a missing launch argument
timer_rateto the external_cmd_converter. This parameter is used to set the update rate of the timer. The default value for this parameter is 10.0. The changes have been reflected in both .py and .xml launch files.The error was ocurring when psim is launched as follows
Tests performed
confirmed error disappeared with this change
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.