Skip to content

Commit 4887bdc

Browse files
authoredNov 30, 2023
fix(external_cmd_converter): define timer_rate parameter (#5719)
The commit introduces a missing launch argument "timer_rate" to the external_cmd_converter. This parameter is used to set the update rate of the timer. The default value for this parameter is 10.0. The changes have been reflected in both .py and .xml launch files. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
1 parent 05e9c89 commit 4887bdc

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed
 

‎vehicle/external_cmd_converter/launch/external_cmd_converter.launch.py

+6
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ def generate_launch_description():
5252
default_value="3.0",
5353
description="gain for external command accel",
5454
),
55+
DeclareLaunchArgument(
56+
"timer_rate",
57+
default_value="10.0",
58+
description="timer's update rate",
59+
),
5560
DeclareLaunchArgument(
5661
"wait_for_first_topic",
5762
default_value="true",
@@ -118,6 +123,7 @@ def generate_launch_description():
118123
_create_mapping_tuple("csv_path_accel_map"),
119124
_create_mapping_tuple("csv_path_brake_map"),
120125
_create_mapping_tuple("ref_vel_gain"),
126+
_create_mapping_tuple("timer_rate"),
121127
_create_mapping_tuple("wait_for_first_topic"),
122128
_create_mapping_tuple("control_command_timeout"),
123129
_create_mapping_tuple("emergency_stop_timeout"),

‎vehicle/external_cmd_converter/launch/external_cmd_converter.launch.xml

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
<!-- settings -->
88
<arg name="ref_vel_gain" default="3.0"/>
9+
<arg name="timer_rate" default="10.0"/>
910
<arg name="wait_for_first_topic" default="true"/>
1011
<arg name="control_command_timeout" default="1.0"/>
1112
<arg name="emergency_stop_timeout" default="3.0"/>
@@ -26,6 +27,7 @@
2627
<param name="csv_path_accel_map" value="$(var csv_path_accel_map)"/>
2728
<param name="csv_path_brake_map" value="$(var csv_path_brake_map)"/>
2829
<param name="ref_vel_gain" value="$(var ref_vel_gain)"/>
30+
<param name="timer_rate" value="$(var timer_rate)"/>
2931
<param name="wait_for_first_topic" value="$(var wait_for_first_topic)"/>
3032
<param name="control_command_timeout" value="$(var control_command_timeout)"/>
3133
<param name="emergency_stop_timeout" value="$(var emergency_stop_timeout)"/>

0 commit comments

Comments
 (0)
Please sign in to comment.