Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_multi_object_tracker): selective update per channel #10277

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Mar 17, 2025

Description

  • add configuration channel detection options
    • can_spawn_new_tracker
    • can_trust_existence_probability
    • can_trust_extension
    • can_trust_classification
    • can_trust_orientation
  • implement partial update of detection
    • ex1: if can_trust_existence_probability is false, use 0.6 as default
    • ex2: if can_trust_extension is false, do not update object size
  • integrate the bicycle tracker into the vehicle tracker

Related links

Launcher PR autowarefoundation/autoware_launch#1364

How was this PR tested?

By default, the input channel is only 'detected_objects', correspond to non multi-channel mode.
The multi-channel mode is under development.

Test is conducted to confirm the node is work as before.

TIER IV INTERNAL

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin self-assigned this Mar 17, 2025
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 17, 2025
Copy link

github-actions bot commented Mar 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…angle in state prediction

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…uration by removing trust flags and consolidating parameters"

This reverts commit c5155ef.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
… include InputChannel parameter

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…cleMotionModel and update measurement logic in VehicleTracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…ude InputChannel parameter and adjust related logic

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…rences to use VehicleTracker

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…ion based on motion model

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…h VehicleTracker in relevant classes

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…tation in radar configurations

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the feat/multi-object-tracker/selective-update-per-channel branch from 9720db5 to 1a1b9ef Compare March 18, 2025 10:08
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 19, 2025
return false;
}

// update object size
constexpr double gain = 0.5;
constexpr double gain = 0.4;
Copy link
Contributor Author

@technolojin technolojin Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameter is adjusted to corporate bicycle and vehicle trackers

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 26.05%. Comparing base (7686e5a) to head (1a1b9ef).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ject_tracker/lib/tracker/model/vehicle_tracker.cpp 0.00% 20 Missing ⚠️
.../lib/tracker/motion_model/bicycle_motion_model.cpp 0.00% 18 Missing ⚠️
...i_object_tracker/src/multi_object_tracker_node.cpp 0.00% 9 Missing ⚠️
...e_multi_object_tracker/src/processor/processor.cpp 0.00% 6 Missing ⚠️
..._object_tracker/lib/tracker/model/tracker_base.cpp 0.00% 5 Missing ⚠️
...b/tracker/model/pedestrian_and_bicycle_tracker.cpp 0.00% 4 Missing ⚠️
...ker/lib/tracker/model/multiple_vehicle_tracker.cpp 0.00% 3 Missing ⚠️
...t_tracker/lib/tracker/model/pedestrian_tracker.cpp 0.00% 3 Missing ⚠️
...tracker/lib/tracker/model/pass_through_tracker.cpp 0.00% 1 Missing ⚠️
...ject_tracker/lib/tracker/model/unknown_tracker.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10277      +/-   ##
==========================================
- Coverage   26.05%   26.05%   -0.01%     
==========================================
  Files        1374     1374              
  Lines      106351   106354       +3     
  Branches    40877    40858      -19     
==========================================
- Hits        27709    27708       -1     
- Misses      75940    75944       +4     
  Partials     2702     2702              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 26.07% <ø> (∅) Carriedforward from 7686e5a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…schema

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant