Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mpc_lateral_controller): align the MPC steering angle when the car is controlled manually. #7109

Merged
merged 11 commits into from
Jun 20, 2024
+2 −2

pre-commit

0eeaf6d
Select commit
Loading
Failed to load commit list.
Merged

fix(mpc_lateral_controller): align the MPC steering angle when the car is controlled manually. #7109

pre-commit
0eeaf6d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 20, 2024 in 42s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method mpc_lateral_controller.cpp: MpcLateralController::run

Annotations

Check warning on line 263 in control/autoware_mpc_lateral_controller/src/mpc_lateral_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

MpcLateralController::run increases in cyclomatic complexity from 12 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis