-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mrm_handler): add mrm_handler #6400
feat(mrm_handler): add mrm_handler #6400
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6400 +/- ##
==========================================
- Coverage 14.72% 14.69% -0.04%
==========================================
Files 1900 1903 +3
Lines 130361 130630 +269
Branches 38381 38381
==========================================
Hits 19198 19198
- Misses 89647 89916 +269
Partials 21516 21516
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e82b218
to
5b4f753
Compare
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
52bc8a7
to
e6eb715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: add mrm_handler Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * style(pre-commit): autofix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: update README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: refactor isArrivedAtGoal() Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix error massages gramatically. Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: update the person in charge of the unimplemented parts Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix typo in schema.json Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix copyright Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix mistakes in README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: correct a type mistake in README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * style(pre-commit): autofix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> --------- Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* feat: add mrm_handler Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * style(pre-commit): autofix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: update README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: refactor isArrivedAtGoal() Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix error massages gramatically. Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: update the person in charge of the unimplemented parts Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix typo in schema.json Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix copyright Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix mistakes in README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: correct a type mistake in README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * style(pre-commit): autofix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> --------- Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com>
* feat: add mrm_handler Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * style(pre-commit): autofix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: update README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: refactor isArrivedAtGoal() Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix error massages gramatically. Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat: update the person in charge of the unimplemented parts Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix typo in schema.json Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix copyright Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: fix mistakes in README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * modify: correct a type mistake in README Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * style(pre-commit): autofix Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> --------- Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com>
Description
This PR adds mrm_handler node that is going to be replaced with emergency_handler node.
The difference from emergency_handler is that mrm_handler node uses operation_mode_availability while emergency_handler uses hazard_status.
Related links
Tests performed
Confirmed that mrm_handler has the same functionality as emergency_handler.
Confirmed that pull_over functionality can be executed.
Confirmed that behavior transitions from pull_over to comfortable_stop and emergency_stop.
Notes for reviewers
To transition from emergency_handler to mrm_handler,
Interface changes
Effects on system behavior
This change not only allows for the execution of various MRM behaviors that could not be expressed in hazard_status, but also allows for extensibility of MRM behaviors.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.