Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrm_handler): add mrm_handler #6400

Merged
merged 12 commits into from
Feb 28, 2024

Merge branch 'main' into feat/add-mrm-handler

30b2db8
Select commit
Loading
Failed to load commit list.
Merged

feat(mrm_handler): add mrm_handler #6400

Merge branch 'main' into feat/add-mrm-handler
30b2db8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 27, 2024 in 38s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 11 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method mrm_handler_core.cpp: MrmHandler::getCurrentMrmBehavior
  • Overall Code Complexity mrm_handler_core.cpp
  • Bumpy Road Ahead mrm_handler_core.cpp: MrmHandler::getCurrentMrmBehavior
  • Complex Method mrm_handler_core.cpp: MrmHandler::updateMrmState
  • Bumpy Road Ahead mrm_handler_core.cpp: MrmHandler::updateMrmState
  • Deep, Nested Complexity mrm_handler_core.cpp: MrmHandler::onOperationModeAvailability
  • Deep, Nested Complexity mrm_handler_core.cpp: MrmHandler::updateMrmState
  • Bumpy Road Ahead mrm_handler_core.cpp: MrmHandler::onOperationModeAvailability
  • Bumpy Road Ahead mrm_handler_core.cpp: MrmHandler::callMrmBehavior
  • Bumpy Road Ahead mrm_handler_core.cpp: MrmHandler::cancelMrmBehavior
  • Bumpy Road Ahead mrm_handler_core.cpp: MrmHandler::operateMrm

Annotations

Check warning on line 565 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

MrmHandler::getCurrentMrmBehavior has a cyclomatic complexity of 25, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 496 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

MrmHandler::updateMrmState has a cyclomatic complexity of 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 565 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MrmHandler::getCurrentMrmBehavior has 7 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 496 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MrmHandler::updateMrmState has 6 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 140 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MrmHandler::onOperationModeAvailability has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 290 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MrmHandler::callMrmBehavior has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 332 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MrmHandler::cancelMrmBehavior has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 248 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

MrmHandler::operateMrm has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 4.95 across 22 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 140 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

MrmHandler::onOperationModeAvailability has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 496 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

MrmHandler::updateMrmState has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.