-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lane_change): fix dynamic reconfigure and add parameters #6276
Merged
zulfaqar-azmi-t4
merged 3 commits into
autowarefoundation:main
from
zulfaqar-azmi-t4:fix-lc-dynamic-reconfigure
Feb 19, 2024
Merged
fix(lane_change): fix dynamic reconfigure and add parameters #6276
zulfaqar-azmi-t4
merged 3 commits into
autowarefoundation:main
from
zulfaqar-azmi-t4:fix-lc-dynamic-reconfigure
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6276 +/- ##
=======================================
Coverage 14.99% 14.99%
=======================================
Files 1839 1839
Lines 127158 127169 +11
Branches 38099 38123 +24
=======================================
+ Hits 19070 19074 +4
+ Misses 86755 86710 -45
- Partials 21333 21385 +52
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
satoshi-ota
approved these changes
Feb 16, 2024
3f94f2c
to
9b32d69
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
9b32d69
to
25bc553
Compare
e329fda
into
autowarefoundation:main
20 of 23 checks passed
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 22, 2024
…efoundation#6276) * fix(lane_change): fix dynamic reconfigure and add parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed unused header Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * clear marker earlier Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 23, 2024
…efoundation#6276) * fix(lane_change): fix dynamic reconfigure and add parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed unused header Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * clear marker earlier Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 23, 2024
…efoundation#6276) * fix(lane_change): fix dynamic reconfigure and add parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed unused header Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * clear marker earlier Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…efoundation#6276) * fix(lane_change): fix dynamic reconfigure and add parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed unused header Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * clear marker earlier Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 7, 2024
…efoundation#6276) * fix(lane_change): fix dynamic reconfigure and add parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed unused header Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * clear marker earlier Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
* fix(lane_change): fix dynamic reconfigure and add parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed unused header Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * clear marker earlier Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…efoundation#6276) * fix(lane_change): fix dynamic reconfigure and add parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed unused header Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * clear marker earlier Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently dynamic reconfigure is not working in lane change module despite it was supported.
So this PR aims to fix this.
Also, some new parameters is added to the reconfigurable list.
Related links
None
Tests performed
cap-.2024-02-01-15-07-51.mp4
You can also use
rqt_reconfigure
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.