Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner_common): modify drivable area expansion to be able to avoid static objects #10220

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

correct parameters description

59371c8
Select commit
Loading
Failed to load commit list.
Open

feat(behavior_path_planner_common): modify drivable area expansion to be able to avoid static objects #10220

correct parameters description
59371c8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 10, 2025 in 30s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Prevent hotspot decline (1 hotspot with Large Method)
Enforce advisory code health rules (2 files with Large Method, Complex Method)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
behavior_path_planner_node.cpp 1 rule in this hotspot 6.51 → 6.49 Suppress
Enforce advisory code health rules Violations Code Health Impact
footprints.cpp 1 advisory rule 10.00 → 9.69 Suppress
behavior_path_planner_node.cpp 1 advisory rule 6.51 → 6.49 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method behavior_path_planner_node.cpp: BehaviorPathPlannerNode::onSetParam 🔥
  • Complex Method footprints.cpp: create_object_footprints

Annotations

Check warning on line 844 in planning/behavior_path_planner/autoware_behavior_path_planner/src/behavior_path_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

BehaviorPathPlannerNode::onSetParam increases from 89 to 95 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 82 in planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/drivable_area_expansion/footprints.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

create_object_footprints has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.