-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tier4_control_launch): replace python launch with xml #7682
Merged
satoshi-ota
merged 10 commits into
autowarefoundation:main
from
mitukou1109:refactor/control_launch_xml
Jul 4, 2024
Merged
refactor(tier4_control_launch): replace python launch with xml #7682
satoshi-ota
merged 10 commits into
autowarefoundation:main
from
mitukou1109:refactor/control_launch_xml
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
7 tasks
satoshi-ota
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b379abc
to
5312172
Compare
5312172
to
089fb41
Compare
kosuke55
reviewed
Jul 2, 2024
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
takayuki5168
approved these changes
Jul 2, 2024
@mitukou1109 Thanks! Could you fix conflicts... 🙏 |
…control_launch_xml
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…arefoundation#7682) * refactor: add xml version of control launch Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * refactor: remove python version of control launch Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * set default value of trajectory_follower_mode Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * fix file extension to .py Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * fix node name Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * add lanelet info to the metrics Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * style(pre-commit): autofix * Update launch/tier4_control_launch/launch/control.launch.xml Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> --------- Signed-off-by: mitukou1109 <mitukou1109@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…arefoundation#7682) * refactor: add xml version of control launch Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * refactor: remove python version of control launch Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * set default value of trajectory_follower_mode Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * fix file extension to .py Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * fix node name Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * add lanelet info to the metrics Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * style(pre-commit): autofix * Update launch/tier4_control_launch/launch/control.launch.xml Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> --------- Signed-off-by: mitukou1109 <mitukou1109@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* refactor: add xml version of control launch Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * refactor: remove python version of control launch Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * set default value of trajectory_follower_mode Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * fix file extension to .py Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * fix node name Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * add lanelet info to the metrics Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * style(pre-commit): autofix * Update launch/tier4_control_launch/launch/control.launch.xml Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> --------- Signed-off-by: mitukou1109 <mitukou1109@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
…arefoundation#7682) * refactor: add xml version of control launch Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * refactor: remove python version of control launch Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * set default value of trajectory_follower_mode Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * fix file extension to .py Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * fix node name Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * add lanelet info to the metrics Signed-off-by: mitukou1109 <mitukou1109@gmail.com> * style(pre-commit): autofix * Update launch/tier4_control_launch/launch/control.launch.xml Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> --------- Signed-off-by: mitukou1109 <mitukou1109@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
control.launch.py
withcontrol.launch.xml
.Launcher PR: autowarefoundation/autoware_launch#1047
How was this PR tested?
Evaluator: https://evaluation.tier4.jp/evaluation/reports/38dc133f-164c-59e6-b3c3-d4ca11f8326e?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.