Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tier4_control_launch): replace python launch with xml #7682

Merged
merged 10 commits into from
Jul 4, 2024
Merged

refactor(tier4_control_launch): replace python launch with xml #7682

merged 10 commits into from
Jul 4, 2024

Conversation

mitukou1109
Copy link
Contributor

@mitukou1109 mitukou1109 commented Jun 25, 2024 •
edited
Loading

Description

This PR replaces control.launch.py with control.launch.xml.

Launcher PR: autowarefoundation/autoware_launch#1047

How was this PR tested?

Evaluator: https://evaluation.tier4.jp/evaluation/reports/38dc133f-164c-59e6-b3c3-d4ca11f8326e?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jun 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitukou1109 mitukou1109 marked this pull request as ready for review July 2, 2024 00:14
@mitukou1109 mitukou1109 mentioned this pull request Jul 2, 2024
Merged
7 tasks
satoshi-ota
satoshi-ota approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitukou1109 mitukou1109 force-pushed the refactor/control_launch_xml branch from b379abc to 5312172 Compare July 2, 2024 07:59
@mitukou1109 mitukou1109 force-pushed the refactor/control_launch_xml branch from 5312172 to 089fb41 Compare July 2, 2024 08:25
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jul 2, 2024
@mitukou1109 @kosuke55
Update launch/tier4_control_launch/launch/control.launch.xml
63efa16 
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
@satoshi-ota satoshi-ota self-assigned this Jul 3, 2024
@satoshi-ota
Copy link
Contributor

@mitukou1109 Thanks! Could you fix conflicts... 🙏

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2024
@satoshi-ota satoshi-ota merged commit 8d180a1 into autowarefoundation:main Jul 4, 2024
24 checks passed
@kosuke55 kosuke55 mentioned this pull request Jul 4, 2024
Merged
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
@mitukou1109 @pre-commit-ci
@kosuke55 @HansRobo @palas21
refactor(tier4_control_launch): replace python launch with xml (autow…
e9e4b90 
…arefoundation#7682)

* refactor: add xml version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* refactor: remove python version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* set default value of trajectory_follower_mode

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix file extension to .py

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix node name

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* add lanelet info to the metrics

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* Update launch/tier4_control_launch/launch/control.launch.xml

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
@mitukou1109 @pre-commit-ci
@kosuke55 @HansRobo @tby-udel
refactor(tier4_control_launch): replace python launch with xml (autow…
0a1ad5a 
…arefoundation#7682)

* refactor: add xml version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* refactor: remove python version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* set default value of trajectory_follower_mode

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix file extension to .py

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix node name

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* add lanelet info to the metrics

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* Update launch/tier4_control_launch/launch/control.launch.xml

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@mitukou1109 @pre-commit-ci
@kosuke55 @HansRobo
refactor(tier4_control_launch): replace python launch with xml (#7682)
e992dbf 
* refactor: add xml version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* refactor: remove python version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* set default value of trajectory_follower_mode

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix file extension to .py

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix node name

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* add lanelet info to the metrics

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* Update launch/tier4_control_launch/launch/control.launch.xml

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
@mitukou1109 @pre-commit-ci
@kosuke55 @HansRobo @Ariiees
refactor(tier4_control_launch): replace python launch with xml (autow…
9584fd5 
…arefoundation#7682)

* refactor: add xml version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* refactor: remove python version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* set default value of trajectory_follower_mode

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix file extension to .py

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix node name

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* add lanelet info to the metrics

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* Update launch/tier4_control_launch/launch/control.launch.xml

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@mitukou1109 mitukou1109 deleted the refactor/control_launch_xml branch September 13, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosuke55 kosuke55 kosuke55 left review comments

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@satoshi-ota satoshi-ota satoshi-ota approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@tkimura4 tkimura4 Awaiting requested review from tkimura4

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

@soblin soblin Awaiting requested review from soblin

@maxime-clem maxime-clem Awaiting requested review from maxime-clem

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

@amc-nu amc-nu Awaiting requested review from amc-nu

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen

@drwnz drwnz Awaiting requested review from drwnz

@knzo25 knzo25 Awaiting requested review from knzo25

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu

@miursh miursh Awaiting requested review from miursh

@vividf vividf Awaiting requested review from vividf

@YoshiRi YoshiRi Awaiting requested review from YoshiRi

@brkay54 brkay54 Awaiting requested review from brkay54

@beyzanurkaya beyzanurkaya Awaiting requested review from beyzanurkaya

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran

@rej55 rej55 Awaiting requested review from rej55

@mehmetdogru mehmetdogru Awaiting requested review from mehmetdogru

@mkuri mkuri Awaiting requested review from mkuri

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo

@ahmeddesokyebrahim ahmeddesokyebrahim Awaiting requested review from ahmeddesokyebrahim

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66

@go-sakayori go-sakayori Awaiting requested review from go-sakayori

@mkquda mkquda Awaiting requested review from mkquda

@tzhong518 tzhong518 Awaiting requested review from tzhong518

@technolojin technolojin Awaiting requested review from technolojin

@dan-dnn dan-dnn Awaiting requested review from dan-dnn

@manato manato Awaiting requested review from manato

@scepter914 scepter914 Awaiting requested review from scepter914

@kminoda kminoda Awaiting requested review from kminoda

@ktro2828 ktro2828 Awaiting requested review from ktro2828

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi

@Motsu-san Motsu-san Awaiting requested review from Motsu-san

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo

@IshitaTakeshi IshitaTakeshi Awaiting requested review from IshitaTakeshi

@ito-san ito-san Awaiting requested review from ito-san

@TetsuKawa TetsuKawa Awaiting requested review from TetsuKawa

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima

@ambroise-arm ambroise-arm Awaiting requested review from ambroise-arm

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi

@KhalilSelyan KhalilSelyan Awaiting requested review from KhalilSelyan

Assignees

@satoshi-ota satoshi-ota

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mitukou1109 @satoshi-ota @takayuki5168 @kosuke55 @HansRobo