Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_control_launch): replace python launch with xml #7682

Merged

Conversation

mitukou1109
Copy link
Contributor

@mitukou1109 mitukou1109 commented Jun 25, 2024

Description

This PR replaces control.launch.py with control.launch.xml.

Launcher PR: autowarefoundation/autoware_launch#1047

How was this PR tested?

Evaluator: https://evaluation.tier4.jp/evaluation/reports/38dc133f-164c-59e6-b3c3-d4ca11f8326e?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jun 25, 2024
Copy link

github-actions bot commented Jun 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitukou1109 mitukou1109 force-pushed the refactor/control_launch_xml branch from 5312172 to 089fb41 Compare July 2, 2024 08:25
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jul 2, 2024
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
@satoshi-ota satoshi-ota self-assigned this Jul 3, 2024
@satoshi-ota
Copy link
Contributor

@mitukou1109 Thanks! Could you fix conflicts... 🙏

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2024
@satoshi-ota satoshi-ota merged commit 8d180a1 into autowarefoundation:main Jul 4, 2024
24 checks passed
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…arefoundation#7682)

* refactor: add xml version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* refactor: remove python version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* set default value of trajectory_follower_mode

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix file extension to .py

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix node name

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* add lanelet info to the metrics

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* Update launch/tier4_control_launch/launch/control.launch.xml

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…arefoundation#7682)

* refactor: add xml version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* refactor: remove python version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* set default value of trajectory_follower_mode

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix file extension to .py

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix node name

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* add lanelet info to the metrics

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* Update launch/tier4_control_launch/launch/control.launch.xml

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* refactor: add xml version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* refactor: remove python version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* set default value of trajectory_follower_mode

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix file extension to .py

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix node name

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* add lanelet info to the metrics

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* Update launch/tier4_control_launch/launch/control.launch.xml

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…arefoundation#7682)

* refactor: add xml version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* refactor: remove python version of control launch

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* set default value of trajectory_follower_mode

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix file extension to .py

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* fix node name

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* add lanelet info to the metrics

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>

* style(pre-commit): autofix

* Update launch/tier4_control_launch/launch/control.launch.xml

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: mitukou1109 <mitukou1109@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@mitukou1109 mitukou1109 deleted the refactor/control_launch_xml branch September 13, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants