Expose remaining v17 blockchain APIs for v19+

[tnull]

While these API methods were previously exposed for a v17 client, they were not for v19+.

Here, we add the blockchain APIs present in v17 for v19+.

[tcharding]

Bro this is sick!!! Thanks a million for the PR man, super cool. To review it I squashed the whole thing down and then rebase #49 on top of it - and it has green CI. Epic. Let me know how you want to proceed.

A few comments.

1. The first patch doesn't test because get_tx_out needs feature gating (but if we squash its doesnt' matter)
2. I realized that I made a vXY feature in integration_test so that feature gating was easier but then I didn't use it.

[tnull]

The first patch doesn't test because get_tx_out needs feature gating (but if we squash its doesnt' matter)

Ah, true, although somewhat preexisting as gettxout was exposed but broken for v22+. Now switched the commit order to allow squashing the gettxout fix into the first commit before merging.

I realized that I made a vXY feature in integration_test so that feature gating was easier but then I didn't use it.

Good to know, now added a fixup to switch to that.

> git diff-tree -U2 d8c03c1 54c2ddd
diff --git a/integration_test/tests/blockchain.rs b/integration_test/tests/blockchain.rs
index 4f05c34..1666f06 100644
--- a/integration_test/tests/blockchain.rs
+++ b/integration_test/tests/blockchain.rs
@@ -71,5 +71,5 @@ fn get_block_header_verbose() { // verbose = true
 }

-#[cfg(all(not(feature = "0_18_1"), not(feature = "0_19_1"), not(feature = "0_19_1"), not(feature = "0_20_2"), not(feature = "0_21_2"), not(feature = "22_1"), not(feature = "23_2"), not(feature = "24_2")))]
+#[cfg(not(any(feature = "v18", feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
 // `getblockstats` used to not work on the genesis block as it doesn't have undo data saved to disk
 // (see https://github.com/bitcoin/bitcoin/pull/19888). We therefore only run tests for versions
@@ -81,5 +81,5 @@ fn get_block_stats() {
 }

-#[cfg(all(not(feature = "0_18_1"), not(feature = "0_19_1"), not(feature = "0_19_1"), not(feature = "0_20_2"), not(feature = "0_21_2"), not(feature = "22_1"), not(feature = "23_2"), not(feature = "24_2")))]
+#[cfg(not(any(feature = "v18", feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
 // `getblockstats` used to not work on the genesis block as it doesn't have undo data saved to disk
 // (see https://github.com/bitcoin/bitcoin/pull/19888). We therefore only run tests for versions
@@ -91,5 +91,5 @@ fn get_block_stats_by_height() {
 }

-#[cfg(all(not(feature = "0_18_1"), not(feature = "0_19_1"), not(feature = "0_19_1"), not(feature = "0_20_2"), not(feature = "0_21_2"), not(feature = "22_1"), not(feature = "23_2"), not(feature = "24_2")))]
+#[cfg(not(any(feature = "v18", feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
 // `getblockstats` used to not work on the genesis block as it doesn't have undo data saved to disk
 // (see https://github.com/bitcoin/bitcoin/pull/19888). We therefore only run tests for versions
@@ -102,5 +102,5 @@ fn get_block_stats_by_hash() { // verbose = true
 }

-#[cfg(all(not(feature = "0_18_1"), not(feature = "0_19_1"), not(feature = "0_19_1"), not(feature = "0_20_2"), not(feature = "0_21_2"), not(feature = "22_1"), not(feature = "23_2"), not(feature = "24_2")))]
+#[cfg(not(any(feature = "v18", feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
 // `getblockstats` used to not work on the genesis block as it doesn't have undo data saved to disk
 // (see https://github.com/bitcoin/bitcoin/pull/19888). We therefore only run tests for versions
@@ -113,5 +113,5 @@ fn get_block_stats_by_height_txindex() {
 }

-#[cfg(all(not(feature = "0_18_1"), not(feature = "0_19_1"), not(feature = "0_19_1"), not(feature = "0_20_2"), not(feature = "0_21_2"), not(feature = "22_1"), not(feature = "23_2"), not(feature = "24_2")))]
+#[cfg(not(any(feature = "v18", feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
 // `getblockstats` used to not work on the genesis block as it doesn't have undo data saved to disk
 // (see https://github.com/bitcoin/bitcoin/pull/19888). We therefore only run tests for versions
diff --git a/types/src/v19/blockchain.rs b/types/src/v19/blockchain.rs
index d956ded..fe6f961 100644
--- a/types/src/v19/blockchain.rs
+++ b/types/src/v19/blockchain.rs
@@ -345,5 +345,5 @@ pub struct MempoolEntry {
     /// Hash of serialized transaction, including witness data.
     pub wtxid: String,
-    /// (No docs in Core v17.)
+    /// (No docs in Core v19.)
     pub fees: MempoolEntryFees,
     /// Unconfirmed transactions used as inputs for this transaction (parent transaction id).
@@ -399,5 +399,5 @@ impl MempoolEntry {
 }

-/// (No docs in Core v17.)
+/// (No docs in Core v19.)
 #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
 pub struct MempoolEntryFees {

[tnull]

Failing nightly formatting CI job seems unrelated as I'm not touching the parts it's failing on in this PR.

[tnull]

Pushed another fixup allowing to test the txindex variants of get_block_stats for v18:

> git diff-tree -U2 54c2ddd 394d2e5
diff --git a/integration_test/tests/blockchain.rs b/integration_test/tests/blockchain.rs
index 1666f06..87ce52d 100644
--- a/integration_test/tests/blockchain.rs
+++ b/integration_test/tests/blockchain.rs
@@ -102,5 +102,5 @@ fn get_block_stats_by_hash() { // verbose = true
 }

-#[cfg(not(any(feature = "v18", feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
+#[cfg(not(any(feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
 // `getblockstats` used to not work on the genesis block as it doesn't have undo data saved to disk
 // (see https://github.com/bitcoin/bitcoin/pull/19888). We therefore only run tests for versions
@@ -113,5 +113,5 @@ fn get_block_stats_by_height_txindex() {
 }

-#[cfg(not(any(feature = "v18", feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
+#[cfg(not(any(feature = "v19", feature = "v20", feature = "v21", feature = "v22", feature = "v23", feature = "v24")))]
 // `getblockstats` used to not work on the genesis block as it doesn't have undo data saved to disk
 // (see https://github.com/bitcoin/bitcoin/pull/19888). We therefore only run tests for versions

[tnull]

Let me know if I can squash the fixups!

[tcharding]

ACK 394d2e5

[tcharding]

All looks good, squash away!

[tcharding]

I"ll merge #81 so you can rebase on top and get past the formatting job in CI.

[tnull]

Rebased on master after #81 landed.

[tcharding]

ACK 2efcb9e

[tcharding]

v18 is excluded from the getblockstats test again but no sweat we can come back. This is a good step forward, thanks man!

[tnull]

v18 is excluded from the getblockstats test again but no sweat we can come back. This is a good step forward, thanks man!

Well, yes, it's excluded for the non-txindex variants as those fail complaining that txindex needs to be enabled.

[tcharding]

Oh no worries. I had it in mind that we would enable -txindex for all of the getblockstats tests. Its good as is, thanks man. (There is a node constructor that enables it.)