Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release tracking PR: v0.6.0 #49

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Release tracking PR: v0.6.0 #49

wants to merge 2 commits into from

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jan 23, 2025 •
edited
Loading

In preparation for release of all three crates add changelog entries, bump the version number, and update the lock files.

Patch 2 closes #69

@tcharding tcharding marked this pull request as draft January 23, 2025 01:44
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch 2 times, most recently from f22905c to ac517db Compare February 4, 2025 22:42
@tcharding tcharding marked this pull request as ready for review February 4, 2025 22:42
@tcharding tcharding marked this pull request as draft February 5, 2025 04:55
apoelstra
apoelstra approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ac517db; successfully ran local tests

@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch 3 times, most recently from 0490471 to a55fe9b Compare February 6, 2025 22:45
@tcharding tcharding mentioned this pull request Feb 6, 2025
Merged
@tcharding tcharding mentioned this pull request Mar 5, 2025
Open
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch from 894e1d9 to f919d19 Compare March 6, 2025 22:12
@tcharding tcharding mentioned this pull request Mar 6, 2025
Merged
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch from f919d19 to 691a6bd Compare March 6, 2025 22:45
@tcharding
Copy link
Member Author

Changelog for #79 added to client already.

@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch from 691a6bd to 2c2bd87 Compare March 6, 2025 22:55
@tcharding
Copy link
Member Author

Rebased to pick up #74

@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch from 2c2bd87 to 4007035 Compare March 6, 2025 23:18
@tcharding
Copy link
Member Author

Added 1062193

@tcharding
Copy link
Member Author

tcharding commented Mar 6, 2025 •
edited
Loading

Now I broke it. Its bizzare, I can get bitcoin-cli getblockstats 0 to work for v18 etc locally but not in the unit test.

@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch 2 times, most recently from 6918ac9 to 3e9376d Compare March 7, 2025 00:56
@tnull
Copy link
Contributor

tnull commented Mar 7, 2025

Now I broke it. Its bizzare, I can get bitcoin-cli getblockstats 0 to work for v18 etc locally but not in the unit test.

Hmm, do you happen to enable txindex locally? It somehow seems that v18 works, but only the txindex variants. And then [v19, v24] fail all due to RpcError { code: -1, message: "Can't read undo data from disk", data: None }.
Will push a fixup carving out txindex testing for v18 over at #79.

@tcharding
Copy link
Member Author

tcharding commented Mar 7, 2025 •
edited
Loading

That explains my confusion yesterday I must have changed between running tests with v18 and later versions - then I couldn't work out why it worked at some stage. Thanks man, I was very confused by that.

tcharding added 2 commits March 9, 2025 05:39
@tcharding
verify: Add a README file
91a47d7 
Add a brief readme file, point at `cargo run -- --help` and also at the
docs we already wrote in `types/README.md`.
@tcharding
Bump crate versions
8a1883b 
In preparation for release bump the version numbers of `types`,
`client`, and `node` to `0.6.0`.

Add changelog entries to each and update the lock files.
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch from 3e9376d to 8a1883b Compare March 8, 2025 18:39
@tcharding tcharding marked this pull request as ready for review March 8, 2025 18:40
@tcharding tcharding marked this pull request as draft March 8, 2025 18:47
@tcharding
Copy link
Member Author

Will come back and do a quick final sweep of the crates while debugging this and before release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a README to verify
3 participants
@tcharding @tnull @apoelstra