Many v17 APIs are missing for v19+ clients

[tnull]

Looking at client/src/client_sync/v19/mod.rs (and ff.), many of the APIs present in v17 and v18 are missing. One example I just stumbled across is get_block_count.

Is this somehow intentional and pending resolution? Or is this simply a bug and v19+ clients should simply hold all the impl_client_v17__ calls, too?

[tcharding]

Hey man, yeah v17 is the most complete (although still incomplete). I have got all the docs up to date and am waiting to release (#49). Then I'm hoping to get some help to chip away at all the other methods. My intention is to start at 17 and work my way up. I realize v17 is less useful than later versions but keeping impls in the version they first appear seems to have merit. If you build the docs on master you can see exact status for each version by looking at types::vXY::lib.rs (example of rendered version: https://docs.rs/corepc-types/latest/corepc_types/v17/index.html).

I've been fairly lazy with corepc lately, I'll try to be better.

[tnull]

Hey man, yeah v17 is the most complete (although still incomplete).

I'm confused: as long as the methods haven't changed signatures/functionalities, isn't it just a matter of copy/pasting the impl_client_v17__ calls to the respective mod.rss? Take the example of get_block_count: to make it available in v19+, you'd just need to add impl_client_v17__getblockcount!() to all of the other module definitions, or am I missing/misunderstanding something?

[tcharding]

You understand correctly. Also we have to write a test at the same time. Its just a matter of grinding it out. PRs most welcome!!

[tnull]

You understand correctly. Also we have to write a test at the same time. Its just a matter of grinding it out. PRs most welcome!!

Gotcha. Now opened #79 to expose the remaining v17 blockchain methods for v19+.