-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SimpleLogProcessor from log benchmark #1969
Remove SimpleLogProcessor from log benchmark #1969
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
=======================================
- Coverage 74.9% 74.9% -0.1%
=======================================
Files 122 122
Lines 20403 20403
=======================================
- Hits 15290 15289 -1
- Misses 5113 5114 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Please cleanup the NoOp processor to be NoOp, without even requiring an exporter)
CI errors due to updated rust toolchain. Will create a separate PR for this.
|
Changes
Nit change to remove SimpleLogProcessor from the log benchmark. The benchmark is mainly for Logger and LogRecord, the result shouldn't be affected by the mutex lock for SimpleLogProcessor. Simple*Processor is only for testing purposes and can be avoided in general in bench tests. Or else, there can be a separate test for it if required.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes