Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SimpleLogProcessor from log benchmark #1969

Merged
merged 8 commits into from
Jul 27, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 27, 2024

Changes

Nit change to remove SimpleLogProcessor from the log benchmark. The benchmark is mainly for Logger and LogRecord, the result shouldn't be affected by the mutex lock for SimpleLogProcessor. Simple*Processor is only for testing purposes and can be avoided in general in bench tests. Or else, there can be a separate test for it if required.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team July 27, 2024 00:39
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9%. Comparing base (f9076ea) to head (d596ab1).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1969     +/-   ##
=======================================
- Coverage   74.9%   74.9%   -0.1%     
=======================================
  Files        122     122             
  Lines      20403   20403             
=======================================
- Hits       15290   15289      -1     
- Misses      5113    5114      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Please cleanup the NoOp processor to be NoOp, without even requiring an exporter)

@lalitb
Copy link
Member Author

lalitb commented Jul 27, 2024

CI errors due to updated rust toolchain. Will create a separate PR for this.

    Checking opentelemetry-zipkin v0.22.0 (/home/runner/work/opentelemetry-rust/opentelemetry-rust/opentelemetry-zipkin)
error: doc list item missing indentation
 --> opentelemetry-zipkin/src/propagator/mod.rs:6:5
  |
6 | //!    b3: {trace_id}-{span_id}-{sampling_state}-{parent_span_id}
  |     ^^^
  |
  = help: if this is supposed to be its own paragraph, add a blank line
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
  = note: `-D clippy::doc-lazy-continuation` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]`
help: indent this line
  |
6 | //!     b3: {trace_id}-{span_id}-{sampling_state}-{parent_span_id}
  |        +

error: doc list item missing indentation
 --> opentelemetry-zipkin/src/propagator/mod.rs:8:5
  |
8 | //!    X-B3-TraceId: {trace_id}
  |     ^^^
  |
  = help: if this is supposed to be its own paragraph, add a blank line
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
  |
8 | //!     X-B3-TraceId: {trace_id}
  |        +

error: doc list item missing indentation
 --> opentelemetry-zipkin/src/propagator/mod.rs:9:5
  |
9 | //!    X-B3-ParentSpanId: {parent_span_id}
  |     ^^^
  |
  = help: if this is supposed to be its own paragraph, add a blank line
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
  |
9 | //!     X-B3-ParentSpanId: {parent_span_id}
  |        +

error: doc list item missing indentation
  --> opentelemetry-zipkin/src/propagator/mod.rs:10:5
   |
10 | //!    X-B3-SpanId: {span_id}
   |     ^^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
10 | //!     X-B3-SpanId: {span_id}
   |        +

error: doc list item missing indentation
  --> opentelemetry-zipkin/src/propagator/mod.rs:11:5
   |
11 | //!    X-B3-Sampled: {sampling_state}
   |     ^^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
11 | //!     X-B3-Sampled: {sampling_state}
   |        +

error: doc list item missing indentation
  --> opentelemetry-zipkin/src/propagator/mod.rs:12:5
   |
12 | //!    X-B3-Flags: {debug_flag}
   |     ^^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
12 | //!     X-B3-Flags: {debug_flag}
   |        +

error: could not compile `opentelemetry-zipkin` (lib) due to 6 previous errors
warning: build failed, waiting for other jobs to finish...
error: doc list item missing indentation
   --> opentelemetry-zipkin/src/propagator/mod.rs:6:5
    |
6   | //!    b3: {trace_id}-{span_id}-{sampling_state}-{parent_span_id}
    |     ^^^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
note: the lint level is defined here
   --> opentelemetry-zipkin/src/lib.rs:203:24
    |
203 | #![cfg_attr(test, deny(warnings))]
    |                        ^^^^^^^^
    = note: `#[deny(clippy::doc_lazy_continuation)]` implied by `#[deny(warnings)]`
help: indent this line
    |
6   | //!     b3: {trace_id}-{span_id}-{sampling_state}-{parent_span_id}
    |        +

error: could not compile `opentelemetry-zipkin` (lib test) due to 6 previous errors

@cijothomas cijothomas merged commit 4d31408 into open-telemetry:main Jul 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants