Skip to content

Commit 4d31408

Browse files
lalitbcijothomas
andauthored
Remove SimpleLogProcessor from log benchmark (#1969)
Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
1 parent f9076ea commit 4d31408

File tree

1 file changed

+24
-9
lines changed
  • opentelemetry-sdk/benches

1 file changed

+24
-9
lines changed

opentelemetry-sdk/benches/log.rs

+24-9
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use std::collections::HashMap;
77
use std::time::SystemTime;
88

9-
use async_trait::async_trait;
109
use criterion::{criterion_group, criterion_main, Criterion};
1110

1211
use opentelemetry::logs::{
@@ -15,18 +14,34 @@ use opentelemetry::logs::{
1514
use opentelemetry::trace::Tracer;
1615
use opentelemetry::trace::TracerProvider as _;
1716
use opentelemetry::Key;
18-
use opentelemetry_sdk::export::logs::{LogData, LogExporter};
17+
use opentelemetry_sdk::export::logs::LogData;
18+
use opentelemetry_sdk::logs::LogProcessor;
1919
use opentelemetry_sdk::logs::{Logger, LoggerProvider};
2020
use opentelemetry_sdk::trace;
2121
use opentelemetry_sdk::trace::{Sampler, TracerProvider};
2222

2323
#[derive(Debug)]
24-
struct VoidExporter;
24+
struct NoopProcessor;
2525

26-
#[async_trait]
27-
impl LogExporter for VoidExporter {
28-
async fn export<'a>(&mut self, _batch: Vec<std::borrow::Cow<'a, LogData>>) -> LogResult<()> {
29-
LogResult::Ok(())
26+
impl LogProcessor for NoopProcessor {
27+
fn emit(&self, _data: &mut LogData) {}
28+
29+
fn force_flush(&self) -> LogResult<()> {
30+
Ok(())
31+
}
32+
33+
fn shutdown(&self) -> LogResult<()> {
34+
Ok(())
35+
}
36+
37+
#[cfg(feature = "logs_level_enabled")]
38+
fn event_enabled(
39+
&self,
40+
_level: opentelemetry::logs::Severity,
41+
_target: &str,
42+
_name: &str,
43+
) -> bool {
44+
true
3045
}
3146
}
3247

@@ -35,7 +50,7 @@ fn log_benchmark_group<F: Fn(&Logger)>(c: &mut Criterion, name: &str, f: F) {
3550

3651
group.bench_function("no-context", |b| {
3752
let provider = LoggerProvider::builder()
38-
.with_simple_exporter(VoidExporter)
53+
.with_log_processor(NoopProcessor {})
3954
.build();
4055

4156
let logger = provider.logger("no-context");
@@ -45,7 +60,7 @@ fn log_benchmark_group<F: Fn(&Logger)>(c: &mut Criterion, name: &str, f: F) {
4560

4661
group.bench_function("with-context", |b| {
4762
let provider = LoggerProvider::builder()
48-
.with_simple_exporter(VoidExporter)
63+
.with_log_processor(NoopProcessor {})
4964
.build();
5065

5166
let logger = provider.logger("with-context");

0 commit comments

Comments
 (0)