Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SimpleLogProcessor from log benchmark #1969

Merged
merged 8 commits into from
Jul 27, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 41 additions & 5 deletions opentelemetry-sdk/benches/log.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,62 @@ use opentelemetry::trace::Tracer;
use opentelemetry::trace::TracerProvider as _;
use opentelemetry::Key;
use opentelemetry_sdk::export::logs::{LogData, LogExporter};
use opentelemetry_sdk::logs::LogProcessor;
use opentelemetry_sdk::logs::{Logger, LoggerProvider};
use opentelemetry_sdk::trace;
use opentelemetry_sdk::trace::{Sampler, TracerProvider};

#[derive(Debug)]
struct VoidExporter;
struct NoopExporter;

#[async_trait]
impl LogExporter for VoidExporter {
async fn export<'a>(&mut self, _batch: Vec<std::borrow::Cow<'a, LogData>>) -> LogResult<()> {
impl LogExporter for NoopExporter {
async fn export<'a>(&mut self, _: Vec<std::borrow::Cow<'a, LogData>>) -> LogResult<()> {
LogResult::Ok(())
}
}

#[derive(Debug)]
struct NoopProcessor {
_exporter: Box<dyn LogExporter>,
}

impl NoopProcessor {
fn new(exporter: Box<dyn LogExporter>) -> Self {
Self {
_exporter: exporter,
}
}
}

impl LogProcessor for NoopProcessor {
fn emit(&self, _data: &mut LogData) {}

fn force_flush(&self) -> LogResult<()> {
Ok(())
}

fn shutdown(&self) -> LogResult<()> {
Ok(())
}

#[cfg(feature = "logs_level_enabled")]
fn event_enabled(
&self,
_level: opentelemetry::logs::Severity,
_target: &str,
_name: &str,
) -> bool {
true
}
}

fn log_benchmark_group<F: Fn(&Logger)>(c: &mut Criterion, name: &str, f: F) {
let mut group = c.benchmark_group(name);

group.bench_function("no-context", |b| {
let provider = LoggerProvider::builder()
.with_simple_exporter(VoidExporter)
.with_log_processor(NoopProcessor::new(Box::new(NoopExporter)))
.build();

let logger = provider.logger("no-context");
Expand All @@ -45,7 +81,7 @@ fn log_benchmark_group<F: Fn(&Logger)>(c: &mut Criterion, name: &str, f: F) {

group.bench_function("with-context", |b| {
let provider = LoggerProvider::builder()
.with_simple_exporter(VoidExporter)
.with_log_processor(NoopProcessor::new(Box::new(NoopExporter)))
.build();

let logger = provider.logger("with-context");
Expand Down
Loading