Move out payload builder service from reth #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
requested review from
dvush,
ZanCorDX,
ferranbt and
metachris
as code owners
SozinM
force-pushed
the
msozin/op-rbuilder/payload_builder_service
branch
from
e3d8b25 to
b2c1055
Compare
SozinM
force-pushed
the
msozin/op-rbuilder/payload_builder_service
branch
from
b2c1055 to
84aad95
Compare
This was referenced Feb 24, 2025
Closed
avalonche
reviewed
Feb 25, 2025
There was a problem hiding this comment.
what's the plan to maintain upstream changes with Reth's payload building service?
There was a problem hiding this comment.
i think with this approach it's possible to us to fix this struct and stop getting upstream changes
It will work until fundamental changes, that change model of engine_FCU and engine_getPayload
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR reduces our reliance on Reth by taking direct ownership of the main block-building component. Doing so prevents potential disruptions from future Reth interface changes, ensuring a more stable and predictable development process.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test