Remove task trait #439
Remove task trait #439
Conversation
have an error with lifetime of &self with executor.spawn_blocking
SozinM
force-pushed
the
msozin/op-rbuilder/remove-task-trait
branch
from
ffdb8b0 to
3ba33f1
Compare
SozinM
force-pushed
the
msozin/op-rbuilder/remove-task-trait
branch
from
aa222d2 to
49682b0
Compare
Fix hanging test
SozinM
force-pushed
the
msozin/op-rbuilder/remove-task-trait
branch
from
80d0691 to
55d7299
Compare
| @@ -260,24 +251,19 @@ where | |||
|
|
|||
| let (tx, rx) = oneshot::channel(); | |||
| self.build_complete = Some(rx); | |||
| let args = BuildArguments { | |||
There was a problem hiding this comment.
I imagined that it would be PayloadGenerator the one spawning the job instead of the PayloadBuilder impl.
There was a problem hiding this comment.
I could move this too into the OpPayloadBuilderVanilla.
I will add config and cancel to the try_build and then see if we could refactor this somehow.
There was a problem hiding this comment.
I could move this too into the OpPayloadBuilderVanilla.
Forget about the highlighted line, I could not highlight the correct part of the code since it was not modified.
There was a problem hiding this comment.
Seems like i read initial message wrong.
You man to move spawning into new_payload_job of BlockPayloadJobGenerator, right?
There was a problem hiding this comment.
Ideally i would change interface in this place a bit.
I would like to see the following:
Instead of resolving per-job we would me payload resolving logic into BlockPayloadJobGenerator
The BlockPayloadJobGenerator would coordinate all BlockPayloadJob spawned for this payload building and will ultimately return response to PayloadBuilderService
|
Will do it differently on top of #443 chain |
📝 Summary
Could be merged after #436
Closes #428
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test