Remove Tasks trait from PayloadJobGenerator and PayloadJob #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Solves #428
Removes
Tasks
trait fromBlockPayloadJobGenerator
andBlockPayloadJob
. Replaces the singular usage of the Task Executor insidespawn_build_job
with a direct call to the Tokio task spawner to replicate previous behaviour without needing the trait implementation.💡 Motivation and Context
Makes it simpler to mock the payload job generator and payload job types without needing to involve a task executor.
✅ I have completed the following steps:
make lint
make test