Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tasks trait from PayloadJobGenerator and PayloadJob #437

Conversation

haardikk21
Copy link

📝 Summary

Solves #428

Removes Tasks trait from BlockPayloadJobGenerator and BlockPayloadJob. Replaces the singular usage of the Task Executor inside spawn_build_job with a direct call to the Tokio task spawner to replicate previous behaviour without needing the trait implementation.

💡 Motivation and Context

Makes it simpler to mock the payload job generator and payload job types without needing to involve a task executor.


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@haardikk21
Copy link
Author

Closing due to redundancy with work being done on #443

@haardikk21 haardikk21 closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant