docs: Add DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT to the docs #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshpr
changed the title
|
Hey @freshpr, thanks for your contribution, could you please sign your commits? |
csatib02
approved these changes
Feb 23, 2025
Missing DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT in the docs made it a bit unclear what had to be done exactly. I had to look in the code to see that all 3 are needed. I expected service account to be by "default" by default. Signed-off-by: Bence Csati <bence.csati@axoflow.com> Co-authored-by: freshpr <65549906+freshpr@users.noreply.github.com>
csatib02
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT in the docs made it a bit unclear what had to be done exactly.
I had to look in the code to see that all 3 were needed.