Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT to the docs #247

Merged
merged 1 commit into from
Feb 25, 2025
Merged

docs: Add DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT to the docs #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions content/docs/mutating-webhook/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,9 @@ helm upgrade --install mysql stable/mysql \

## Registry access

You can also specify a default secret being used by the webhook for cases where a pod has no `imagePullSecrets` specified. To make this work you have to set the environment variables `DEFAULT_IMAGE_PULL_SECRET` and `DEFAULT_IMAGE_PULL_SECRET_NAMESPACE` when deploying the vault-secrets-webhook. Have a look at the [values.yaml of the
vault-secrets-webhook](https://github.com/bank-vaults/vault-secrets-webhook/blob/v{{< param "latest_version" >}}/deploy/charts/vault-secrets-webhook/values.yaml) helm chart to see how this is done.
You can also specify a default secret being used by the webhook for cases where a pod has no `imagePullSecrets` specified. To make this work you have to set the following environment variables when deploying the vault-secrets-webhook: `DEFAULT_IMAGE_PULL_SECRET`, `DEFAULT_IMAGE_PULL_SECRET_NAMESPACE` and `DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT`.

Have a look at the [values.yaml of the vault-secrets-webhook](https://github.com/bank-vaults/vault-secrets-webhook/blob/v{{< param "latest_version" >}}/deploy/charts/vault-secrets-webhook/values.yaml) helm chart to see how this is done.

> Note:
> - If your EC2 nodes have the ECR instance role, the webhook can request an ECR access token through that role automatically, instead of an explicit `imagePullSecret`
Expand Down
Loading