Skip to content

Commit 1461c21

Browse files
freshprcsatib02
andauthored
docs: Add DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT to the docs (#247)
Missing DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT in the docs made it a bit unclear what had to be done exactly. I had to look in the code to see that all 3 are needed. I expected service account to be by "default" by default. Signed-off-by: Bence Csati <bence.csati@axoflow.com> Co-authored-by: Bence Csati <bence.csati@axoflow.com>
1 parent db2d4ab commit 1461c21

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

content/docs/mutating-webhook/configuration.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,9 @@ helm upgrade --install mysql stable/mysql \
195195

196196
## Registry access
197197

198-
You can also specify a default secret being used by the webhook for cases where a pod has no `imagePullSecrets` specified. To make this work you have to set the environment variables `DEFAULT_IMAGE_PULL_SECRET` and `DEFAULT_IMAGE_PULL_SECRET_NAMESPACE` when deploying the vault-secrets-webhook. Have a look at the [values.yaml of the
199-
vault-secrets-webhook](https://github.com/bank-vaults/vault-secrets-webhook/blob/v{{< param "latest_version" >}}/deploy/charts/vault-secrets-webhook/values.yaml) helm chart to see how this is done.
198+
You can also specify a default secret being used by the webhook for cases where a pod has no `imagePullSecrets` specified. To make this work you have to set the following environment variables when deploying the vault-secrets-webhook: `DEFAULT_IMAGE_PULL_SECRET`, `DEFAULT_IMAGE_PULL_SECRET_NAMESPACE` and `DEFAULT_IMAGE_PULL_SECRET_SERVICE_ACCOUNT`.
199+
200+
Have a look at the [values.yaml of the vault-secrets-webhook](https://github.com/bank-vaults/vault-secrets-webhook/blob/v{{< param "latest_version" >}}/deploy/charts/vault-secrets-webhook/values.yaml) helm chart to see how this is done.
200201

201202
> Note:
202203
> - If your EC2 nodes have the ECR instance role, the webhook can request an ECR access token through that role automatically, instead of an explicit `imagePullSecret`

0 commit comments

Comments
 (0)