-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run extension SQL script with default search_path = pg_catalog #3486
Open
SiddharthBITS
wants to merge
32
commits into
babelfish-for-postgresql:BABEL_5_X_DEV
Choose a base branch
from
SiddharthBITS:Difference-in-search-path
base: BABEL_5_X_DEV
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 31 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
c775f57
Testing ALTER ROLE runner SET search_path TO PG_CATALOG; on all tests
SiddharthBITS 32dff7c
Testing babelfishpg_tsql--4.2.0--4.3.0.sql without pg_catalog
SiddharthBITS 174a898
Testing without double quotes and fixing TestSparsevecDatatype and Te…
SiddharthBITS 34cc446
TSQL Command
SiddharthBITS 37ecd80
Running tests again
SiddharthBITS 36632a7
Changing to localhost
SiddharthBITS becea28
Running tests again
SiddharthBITS d26cc55
Changing path in indivisual tests
SiddharthBITS 58c346b
SELECT pg_catalog.string_agg
SiddharthBITS 2066a9b
Revert changes made after commit 36632a7
SiddharthBITS a9bc2a5
(SELECT pg_catalog.string_agg(
SiddharthBITS dba067c
Ading GO to query
SiddharthBITS 899c4f6
PSQL Commands
SiddharthBITS 7a74190
(SELECT string_agg(
SiddharthBITS 0759c6e
Running alter role only on upgrade tests
SiddharthBITS 26a719d
Alter after restart
SiddharthBITS f8a2c27
Moving restart around
SiddharthBITS 14b9502
Merge branch 'babelfish-for-postgresql:BABEL_5_X_DEV' into Difference…
SiddharthBITS be05649
Altering search_path inside a transaction
SiddharthBITS 79600b8
Running tests again
SiddharthBITS d941e4d
Running tests again
SiddharthBITS d59e535
Running tests again with updated engine
SiddharthBITS 724dc35
Updating 16X engine branch
SiddharthBITS 323549d
Alterting extensions in transactions
SiddharthBITS 6a95a40
Removing debugging, Alter extensions inside transactions
SiddharthBITS f8b6a66
Addressing review comments
SiddharthBITS 4ce0fed
Updating db to postgres in dump restore
SiddharthBITS 76fd91a
Adding pg_catalog
SiddharthBITS f855c89
Sign off
SiddharthBITS c02ebce
No transactions for alter role
SiddharthBITS 96471df
Keeping default search path in major version upgrade
SiddharthBITS 2a37c67
Minor debugging cleanup
SiddharthBITS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -116,6 +116,8 @@ jobs: | |
sudo echo "host all all ::/0 md5" | ||
} > pg_hba.conf | ||
~/${{env.OLD_INSTALL_DIR}}/bin/pg_ctl -c -D ~/${{env.OLD_INSTALL_DIR}}/data -l ~/${{env.OLD_INSTALL_DIR}}/data/logfile restart | ||
# Testing default case without updated search path | ||
# sudo ~/${{env.OLD_INSTALL_DIR}}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;" | ||
Comment on lines
+119
to
+120
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool, this will ensure our upgrade script is tested both ways forcing objects to be schema qualified. |
||
cd ~/work/babelfish_extensions/babelfish_extensions/ | ||
sudo ~/${{env.OLD_INSTALL_DIR}}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -v user="jdbc_user" -v db="babelfish_db" -v migration_mode="multi-db" -v tsql_port="1433" -f .github/scripts/create_extension.sql | ||
sqlcmd -S localhost -U jdbc_user -P 12345678 -Q "SELECT @@version GO" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to remove this as it can be used to debug the extension versions prior to extension update