Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run extension SQL script with default search_path = pg_catalog #3486

Open
wants to merge 32 commits into
base: BABEL_5_X_DEV
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
c775f57
Testing ALTER ROLE runner SET search_path TO PG_CATALOG; on all tests
SiddharthBITS Feb 12, 2025
32dff7c
Testing babelfishpg_tsql--4.2.0--4.3.0.sql without pg_catalog
SiddharthBITS Feb 12, 2025
174a898
Testing without double quotes and fixing TestSparsevecDatatype and Te…
SiddharthBITS Feb 12, 2025
34cc446
TSQL Command
SiddharthBITS Feb 12, 2025
37ecd80
Running tests again
SiddharthBITS Feb 12, 2025
36632a7
Changing to localhost
SiddharthBITS Feb 12, 2025
becea28
Running tests again
SiddharthBITS Feb 12, 2025
d26cc55
Changing path in indivisual tests
SiddharthBITS Feb 13, 2025
58c346b
SELECT pg_catalog.string_agg
SiddharthBITS Feb 13, 2025
2066a9b
Revert changes made after commit 36632a7
SiddharthBITS Feb 13, 2025
a9bc2a5
(SELECT pg_catalog.string_agg(
SiddharthBITS Feb 13, 2025
dba067c
Ading GO to query
SiddharthBITS Feb 13, 2025
899c4f6
PSQL Commands
SiddharthBITS Feb 13, 2025
7a74190
(SELECT string_agg(
SiddharthBITS Feb 13, 2025
0759c6e
Running alter role only on upgrade tests
SiddharthBITS Feb 13, 2025
26a719d
Alter after restart
SiddharthBITS Feb 13, 2025
f8a2c27
Moving restart around
SiddharthBITS Feb 13, 2025
14b9502
Merge branch 'babelfish-for-postgresql:BABEL_5_X_DEV' into Difference…
SiddharthBITS Feb 13, 2025
be05649
Altering search_path inside a transaction
SiddharthBITS Feb 13, 2025
79600b8
Running tests again
SiddharthBITS Feb 13, 2025
d941e4d
Running tests again
SiddharthBITS Feb 14, 2025
d59e535
Running tests again with updated engine
SiddharthBITS Feb 14, 2025
724dc35
Updating 16X engine branch
SiddharthBITS Feb 14, 2025
323549d
Alterting extensions in transactions
SiddharthBITS Feb 14, 2025
6a95a40
Removing debugging, Alter extensions inside transactions
SiddharthBITS Feb 14, 2025
f8b6a66
Addressing review comments
SiddharthBITS Feb 17, 2025
4ce0fed
Updating db to postgres in dump restore
SiddharthBITS Feb 17, 2025
76fd91a
Adding pg_catalog
SiddharthBITS Feb 17, 2025
f855c89
Sign off
SiddharthBITS Feb 17, 2025
c02ebce
No transactions for alter role
SiddharthBITS Feb 17, 2025
96471df
Keeping default search path in major version upgrade
SiddharthBITS Feb 17, 2025
2a37c67
Minor debugging cleanup
SiddharthBITS Feb 17, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/composite-actions/dump-restore-util/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ runs:

# Create and initialise Babelfish extensions in the new server to perform restore.
sudo ~/${{ inputs.pg_new_dir }}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -v user="jdbc_user" -v db="babelfish_db" -v migration_mode=${{inputs.migration_mode}} -v tsql_port="1433" -f .github/scripts/create_extension.sql
sudo ~/${{ inputs.pg_new_dir }}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;"

if [[ ${{ inputs.database_level }} == false ]];then
echo "Starting to restore whole Babelfish physical database"
Expand Down
1 change: 1 addition & 0 deletions .github/composite-actions/install-extensions/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ runs:
sudo echo "babelfishpg_tsql.server_collation_name = '${{ inputs.server_collation_name }}'" >> postgresql.conf
fi
~/${{inputs.install_dir}}/bin/pg_ctl -c -D ~/${{inputs.install_dir}}/$DATADIR/ -l logfile start
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;"
cd ~/work/babelfish_extensions/babelfish_extensions/
sudo ~/${{inputs.install_dir}}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -p ${{inputs.psql_port}} -v user="jdbc_user" -v db="babelfish_db" -v migration_mode=${{inputs.migration_mode}} -v tsql_port=${{inputs.tsql_port}} -v parallel_query_mode=${{inputs.parallel_query_mode}} -f .github/scripts/create_extension.sql
~/${{inputs.install_dir}}/bin/pg_ctl -c -D ~/${{inputs.install_dir}}/$DATADIR/ -l logfile restart
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ runs:
cd ~
~/${{ inputs.install_dir }}/bin/pg_ctl -c -D ~/${{ inputs.install_dir }}/data/ -l logfile restart
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "\dx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to remove this as it can be used to debug the extension versions prior to extension update

sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER EXTENSION "babelfishpg_common" UPDATE;"
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER EXTENSION "babelfishpg_tsql" UPDATE;"
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;"
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "BEGIN; ALTER EXTENSION "babelfishpg_common" UPDATE; ALTER EXTENSION "babelfishpg_tsql" UPDATE; COMMIT;"
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "\dx"
sqlcmd -S localhost -U jdbc_user -P 12345678 -Q "SELECT @@version GO"
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/composite-actions/run-pg-upgrade/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ runs:
echo 'Updating babelfish extensions...'
cd ~/work/babelfish_extensions/babelfish_extensions/
~/${{ inputs.pg_new_dir }}/bin/pg_ctl -c -D ~/${{ inputs.pg_new_dir }}/data -l ~/${{ inputs.pg_new_dir }}/data/logfile start
sudo ~/${{ inputs.pg_new_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER EXTENSION babelfishpg_common UPDATE;"
sudo ~/${{ inputs.pg_new_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER EXTENSION babelfishpg_tsql UPDATE;"
sudo ~/${{ inputs.pg_new_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;"
sudo ~/${{ inputs.pg_new_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "BEGIN; ALTER EXTENSION babelfishpg_common UPDATE; ALTER EXTENSION babelfishpg_tsql UPDATE; COMMIT;"
sudo ~/${{ inputs.pg_new_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "\dx"
echo 'Reset bbf database settings...'
sudo ~/${{ inputs.pg_new_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER SYSTEM SET babelfishpg_tsql.database_name = 'babelfish_db';"
Expand Down
1 change: 1 addition & 0 deletions .github/composite-actions/setup-base-version/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ runs:
sudo echo "babelfishpg_tsql.server_collation_name = '${{ inputs.server_collation_name }}'" >> ~/${{ inputs.install_dir }}/data/postgresql.conf
fi
~/${{ inputs.install_dir }}/bin/pg_ctl -c -D ~/${{ inputs.install_dir }}/data/ -l logfile restart
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;"
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "CREATE USER jdbc_user WITH SUPERUSER CREATEDB CREATEROLE PASSWORD '12345678' INHERIT;"
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "DROP DATABASE IF EXISTS babelfish_db;"
sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "CREATE DATABASE babelfish_db OWNER jdbc_user;"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/major-version-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ jobs:
sudo echo "host all all ::/0 md5"
} > pg_hba.conf
~/${{env.OLD_INSTALL_DIR}}/bin/pg_ctl -c -D ~/${{env.OLD_INSTALL_DIR}}/data -l ~/${{env.OLD_INSTALL_DIR}}/data/logfile restart
# Testing default case without updated search path
# sudo ~/${{env.OLD_INSTALL_DIR}}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;"
Comment on lines +119 to +120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this will ensure our upgrade script is tested both ways forcing objects to be schema qualified.

cd ~/work/babelfish_extensions/babelfish_extensions/
sudo ~/${{env.OLD_INSTALL_DIR}}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -v user="jdbc_user" -v db="babelfish_db" -v migration_mode="multi-db" -v tsql_port="1433" -f .github/scripts/create_extension.sql
sqlcmd -S localhost -U jdbc_user -P 12345678 -Q "SELECT @@version GO"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/minor-version-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,13 @@ jobs:
cd ~
~/psql/bin/pg_ctl -c -D ~/psql/data/ -l logfile restart
sudo ~/psql/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "\dx"
sudo ~/psql/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER EXTENSION "babelfishpg_common" UPDATE; ALTER EXTENSION "babelfishpg_tsql" UPDATE;"
sudo ~/psql/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;"
sudo ~/psql/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "BEGIN; ALTER EXTENSION "babelfishpg_common" UPDATE; ALTER EXTENSION "babelfishpg_tsql" UPDATE; COMMIT;"
sudo ~/psql/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER SYSTEM SET track_functions = 'pl';"
sudo ~/psql/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "ALTER SYSTEM SET babelfishpg_tsql.migration_mode = 'multi-db';"
sudo ~/psql/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "SELECT pg_reload_conf();"
sudo ~/psql/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "\dx"
sqlcmd -S localhost -U jdbc_user -P 12345678 -Q "SELECT @@version GO"

- name: Run JDBC Tests
id: jdbc
timeout-minutes: 60
Expand Down
2 changes: 1 addition & 1 deletion test/JDBC/expected/TestSparsevecDatatype.out
Original file line number Diff line number Diff line change
Expand Up @@ -1429,7 +1429,7 @@ go

create table t(a sparsevec(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down
4 changes: 2 additions & 2 deletions test/JDBC/expected/TestVectorDatatype.out
Original file line number Diff line number Diff line change
Expand Up @@ -1448,7 +1448,7 @@ go

create table t(a vector(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down Expand Up @@ -3020,7 +3020,7 @@ go

create table t(a vector(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1429,7 +1429,7 @@ go

create table t(a sparsevec(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1448,7 +1448,7 @@ go

create table t(a vector(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down Expand Up @@ -3020,7 +3020,7 @@ go

create table t(a vector(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1473,7 +1473,7 @@ go

create table t(a sparsevec(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down
4 changes: 2 additions & 2 deletions test/JDBC/expected/parallel_query/TestVectorDatatype.out
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,7 @@ go

create table t(a vector(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down Expand Up @@ -3210,7 +3210,7 @@ go

create table t(a vector(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#int#!#nvarchar#!#varchar#!#nvarchar#!#int#!#int#!#tinyint#!#smallint#!#int#!#smallint#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar#!#nvarchar
Expand Down
2 changes: 1 addition & 1 deletion test/JDBC/input/datatypes/TestSparsevecDatatype.mix
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ go

create table t(a sparsevec(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
select count(*) from sys.columns where object_id = sys.object_id('t')
go
Expand Down
4 changes: 2 additions & 2 deletions test/JDBC/input/datatypes/TestVectorDatatype.mix
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ go

create table t(a vector(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
select count(*) from sys.columns where object_id = sys.object_id('t')
go
Expand Down Expand Up @@ -1125,7 +1125,7 @@ go

create table t(a vector(3), b varchar(max))
go
select * from information_schema.columns where table_name = 't'
select * from information_schema.columns where table_name = 't' order by column_name
go
select count(*) from sys.columns where object_id = sys.object_id('t')
go
Expand Down
Loading