Run extension SQL script with default search_path = pg_catalog #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiddharthBITS
changed the title
Pull Request Test Coverage Report for Build 13366766524Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Some workflows are failing because your fork has stale head commit for BABEL_* branches |
tanscorpio7
reviewed
Feb 13, 2025
contrib/babelfishpg_tsql/sql/upgrades/babelfishpg_tsql--4.2.0--4.3.0.sql
Outdated
Show resolved
Hide resolved
tanscorpio7
reviewed
Feb 13, 2025
.github/composite-actions/minor-version-upgrade-util/action.yml
Outdated
Show resolved
Hide resolved
Anikait143
reviewed
Feb 14, 2025
.github/composite-actions/minor-version-upgrade-util/action.yml
Outdated
Show resolved
Hide resolved
Anikait143
reviewed
Feb 17, 2025
tanscorpio7
approved these changes
Feb 17, 2025
Comment on lines
+119
to
+120
| # Testing default case without updated search path | ||
| # sudo ~/${{env.OLD_INSTALL_DIR}}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -c "ALTER ROLE runner SET search_path TO PG_CATALOG;" |
There was a problem hiding this comment.
Cool, this will ensure our upgrade script is tested both ways forcing objects to be schema qualified.
SiddharthBITS
changed the title
Anikait143
reviewed
Feb 17, 2025
| @@ -60,9 +60,8 @@ runs: | |||
| ulimit -c unlimited | |||
| cd ~ | |||
| ~/${{ inputs.install_dir }}/bin/pg_ctl -c -D ~/${{ inputs.install_dir }}/data/ -l logfile restart | |||
| sudo ~/${{ inputs.install_dir }}/bin/psql -v ON_ERROR_STOP=1 -d babelfish_db -U runner -c "\dx" | |||
There was a problem hiding this comment.
No need to remove this as it can be used to debug the extension versions prior to extension update
SiddharthBITS
changed the title
SiddharthBITS
changed the title
Anikait143
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There have been a couple of scenarios(BABEL-5362 and BABEL-5595) where we saw upgrade failures which were missed as a part of our github upgrade workflow testing.
When investigated upon we saw a difference in search path in github and gitfarm during upgrade workflows. Also, when tested in OSS with the same search_path as in internal setup, we were able to reproduce the issue.
Key changes:
Task: BABEL-5613
Signed-off-by: Siddharth Sengar sensid@amazon.com
Check List
By submitting this pull request,
I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.