Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto disconnect for the compatible subscriber #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Mar 19, 2025

As part of the review of autowarefoundation/autoware_universe#9453
It was pointed out that the selection of using or not compatible subcribers was unclear.
The reason behind that is that I had issues implementing it automatically, but in this this PR the compatible subscriber (standard ROS messages) is available by default, yet it is disabled as soon as the negotiated type (the blackboard one) is flagged as available.

This makes the add_compatible_sub variable of CudaBlackboardSubscriber deprecated and unused. To avoid breaking autoware.universe:

  • After this PR gets merged, a new release will be made
  • Autoware will bump up the blackboard version to the new release, no changes in autoware will be needed
  • A PR in autoware will delete the use of the now deprecated add_compatible_sub
  • A PR will be made here to remove the variable
  • A new release will be made
  • autoware bumps up to the new version

… case the negotiation succeeded

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant