Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pid_longitudinal_controller): add virtual wall for dry steering and emergency #9685

Merged
merged 2 commits into from
Dec 19, 2024

fix

b82f277
Select commit
Loading
Failed to load commit list.
Merged

feat(pid_longitudinal_controller): add virtual wall for dry steering and emergency #9685

fix
b82f277
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Dec 17, 2024 in 54s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.02 (5.79 -> 5.77)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method pid_longitudinal_controller.cpp: PidLongitudinalController::updateControlState

Annotations

Check warning on line 795 in control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

PidLongitudinalController::updateControlState increases in cyclomatic complexity from 41 to 42, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 4.63 to 4.67, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
View more details on CodeScene Delta Analysis