-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse #7814
fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse #7814
Conversation
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
I think that is also weird. @scepter914 Can you look at this point? |
The function of splitting objects is not implemented yet. So the case that always outputs |
OK, then I will add inline suppression for cppcheck. |
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7814 +/- ##
==========================================
- Coverage 28.55% 28.55% -0.01%
==========================================
Files 1586 1586
Lines 115879 115888 +9
Branches 49384 49387 +3
==========================================
Hits 33093 33093
- Misses 73823 73832 +9
Partials 8963 8963
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…towarefoundation#7814) * fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * inline suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Signed-off-by: palas21 <palas21@itu.edu.tr>
…towarefoundation#7814) * fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * inline suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
…towarefoundation#7814) * fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * inline suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Description
This is a cppcheck warning
What did you mean here?
Maybe my modification
split_object.size() == 1
is incorrect.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.