Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse #7814

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jul 3, 2024

Description

This is a cppcheck warning

perception/radar_fusion_to_detected_object/src/radar_fusion_to_detected_object.cpp:98:32: style: Condition 'split_objects.size()==1' is always true [knownConditionTrueFalse]
      if (split_objects.size() == 1) {
                               ^

What did you mean here?
Maybe my modification split_object.size() == 1 is incorrect.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 3, 2024
@veqcc veqcc self-assigned this Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 3, 2024
@technolojin
Copy link
Contributor

I think that is also weird.

@scepter914 Can you look at this point?

@scepter914
Copy link
Contributor

The function of splitting objects is not implemented yet.
https://github.com/autowarefoundation/autoware.universe/blob/f7b9180d29713fe177b158ea19d7abb994c12b65/perception/radar_fusion_to_detected_object/src/radar_fusion_to_detected_object.cpp#L89

So the case that always outputs 'split_objects.size()==1' is always true works as expected.
It derive from my first design, but I think this package is not used for product and development of this package is low priority for now.

@veqcc
Copy link
Contributor Author

veqcc commented Jul 4, 2024

@scepter914

So the case that always outputs 'split_objects.size()==1' is always true works as expected.
It derive from my first design, but I think this package is not used for product and development of this package is low priority for now.

OK, then I will add inline suppression for cppcheck.
If you complete your implementation, please remove the inline suppression then 👍

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.55%. Comparing base (fbbc44c) to head (71b7a43).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7814      +/-   ##
==========================================
- Coverage   28.55%   28.55%   -0.01%     
==========================================
  Files        1586     1586              
  Lines      115879   115888       +9     
  Branches    49384    49387       +3     
==========================================
  Hits        33093    33093              
- Misses      73823    73832       +9     
  Partials     8963     8963              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 28.55% <ø> (ø) Carriedforward from fbbc44c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit 3d3118a into autowarefoundation:main Jul 4, 2024
29 checks passed
@veqcc veqcc deleted the fix/cppcheck_knownConditionTrueFalse branch July 4, 2024 06:40
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…towarefoundation#7814)

* fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* inline suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…towarefoundation#7814)

* fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* inline suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
)

* fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* inline suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…towarefoundation#7814)

* fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* inline suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants