Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ground_segmentation): fix bug #7771

Merged
merged 5 commits into from
Jul 3, 2024

style(pre-commit): autofix

34b4d77
Select commit
Loading
Failed to load commit list.
Merged

fix(ground_segmentation): fix bug #7771

style(pre-commit): autofix
34b4d77
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jul 2, 2024 in 34s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (9.06 -> 9.06)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method ransac_ground_filter_nodelet.cpp: RANSACGroundFilterComponent::filter

Annotations

Check warning on line 301 in perception/ground_segmentation/src/ransac_ground_filter_nodelet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

RANSACGroundFilterComponent::filter increases from 93 to 94 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis