fix(ground_segmentation): fix bug #7771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
miursh
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7771 +/- ##
==========================================
- Coverage 28.37% 28.37% -0.01%
==========================================
Files 1584 1584
Lines 115596 115605 +9
Branches 49279 49283 +4
==========================================
Hits 32799 32799
- Misses 73849 73858 +9
Partials 8948 8948
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
miursh
requested review from
amc-nu,
badai-nguyen,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:launch
badai-nguyen
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
@miursh Thank you for your pointing out and fixing the bug.
I confirmed that the ransac_ground_filter worked and output pointcloud with desired fields as image by running ros2 launch ground_segmentation ransac_ground_filter.launch.xml inout/pointcloud:=/sensing/lidar/concatenated/pointcloud output/pointcloud:=/ransac_ground_filter/pointcloud
LGTM!
|
@yukkysaito @YoshiRi could you also approve this PR as codeowner of |
Merged
4 tasks
badai-nguyen
pushed a commit
to tier4/autoware_universe
that referenced
this pull request
Jul 3, 2024
badai-nguyen
added a commit
to tier4/autoware_universe
that referenced
this pull request
Jul 4, 2024
…1378) * fix(euclidean_cluster): fix euclidean cluster params (autowarefoundation#7662) * fix(euclidean_cluster): fix max and min cluster size Signed-off-by: beginningfan <beginning.fan@autocore.ai> * fix(gnss_poser): fix a typo Signed-off-by: beginningfan <beginning.fan@autocore.ai> * fix(euclidean_cluster): fix min cluster size Signed-off-by: beginningfan <beginning.fan@autocore.ai> * style(pre-commit): autofix --------- Signed-off-by: beginningfan <beginning.fan@autocore.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(euclidean_cluster): fix max_cluster_size bug (autowarefoundation#7734) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix(ground_segmentation): fix bug (autowarefoundation#7771) --------- Signed-off-by: beginningfan <beginning.fan@autocore.ai> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: beginningfan <103237402+beginningfan@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in ransac ground filter
Related links
Parent Issue:
fix(ground_segmentation): add intensity field #6791
How was this PR tested?
I confirmed that the RANSAC node runs without any errors using a single rosbag on my local PC.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.