Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_launch): modify diagnostic_graph_aggregator_graph argument #7133

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented May 27, 2024

Description

This PR be merged with autowarefoundation/autoware_launch#1000 at the same time.

Tests performed

See autowarefoundation/autoware_launch#1000.

Effects on system behavior

See autowarefoundation/autoware_launch#1000.

Interface changes

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) labels May 27, 2024
@isamu-takagi isamu-takagi marked this pull request as ready for review May 27, 2024 08:34
@isamu-takagi isamu-takagi self-assigned this May 27, 2024
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 27, 2024
…rgument

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@xmfcx xmfcx force-pushed the feat/diagnostic_graph_awsim branch from bc316e6 to 95d066e Compare May 27, 2024 10:40
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmfcx xmfcx merged commit 965fdf4 into autowarefoundation:main May 27, 2024
21 of 22 checks passed
@isamu-takagi isamu-takagi deleted the feat/diagnostic_graph_awsim branch May 27, 2024 11:15
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…rgument (autowarefoundation#7133)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…rgument (autowarefoundation#7133)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…rgument (#7133)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants