Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(side_shift): fix unupdated prev path that caused heavy interpolation #6967

Merged
merged 1 commit into from
May 10, 2024

perf(side_shift): fix unupdated prev path that caused bad extrapolation

5961d77
Select commit
Loading
Failed to load commit list.
Merged

perf(side_shift): fix unupdated prev path that caused heavy interpolation #6967

perf(side_shift): fix unupdated prev path that caused bad extrapolation
5961d77
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded May 10, 2024 in 43s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Complex Method scene.cpp: SideShiftModule::updateData

Annotations

Check notice on line 204 in planning/behavior_path_side_shift_module/src/scene.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method 

SideShiftModule::updateData decreases in cyclomatic complexity from 11 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis