Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(side_shift): fix unupdated prev path that caused heavy interpolation #6967

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented May 10, 2024

Description

Fix #6554

Tests performed

Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/2df90fa5-bb82-5846-bbbe-735a6a541c0e?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 10, 2024
@maxime-clem maxime-clem force-pushed the perf/side_shift-rm-prev_reference_ branch 2 times, most recently from 8e34acf to c15f865 Compare May 10, 2024 05:59
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 10, 2024
@maxime-clem maxime-clem changed the title perf(side_shift): fix unupdated prev path that caused bad extrapolation perf(side_shift): fix unupdated prev path that caused heavy interpolation May 10, 2024
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the perf/side_shift-rm-prev_reference_ branch from c15f865 to 5961d77 Compare May 10, 2024 11:30
@github-actions github-actions bot removed the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 10, 2024
@maxime-clem maxime-clem marked this pull request as ready for review May 10, 2024 11:38
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 10, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

@maxime-clem maxime-clem merged commit c24ad46 into autowarefoundation:main May 10, 2024
31 of 33 checks passed
@maxime-clem maxime-clem deleted the perf/side_shift-rm-prev_reference_ branch May 10, 2024 12:40
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…tion (autowarefoundation#6967)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…tion (autowarefoundation#6967)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
go-sakayori pushed a commit to tier4/autoware_universe that referenced this pull request Jun 20, 2024
…tion (autowarefoundation#6967)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
shmpwk pushed a commit to tier4/autoware_universe that referenced this pull request Jun 20, 2024
perf(side_shift): fix unupdated prev path that caused heavy interpolation (autowarefoundation#6967)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior Planner Time Consumption Due to side_shift Module
2 participants