feat(goal_planner): fix non-thread-safe access in goal_planner (revert of #6809 and minor fix) #6965
+715
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soblin
requested review from
danielsanchezaran,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
soblin
added
the
run:build-and-test-differential
kosuke55
approved these changes
May 10, 2024
…ner (autowarefoundation#6740) (autowarefoundation#6809)" This reverts commit de21d1a. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…t of autowarefoundation#6809 and minor fix) (autowarefoundation#6965) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2024
…t of autowarefoundation#6809 and minor fix) (autowarefoundation#6965) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…t of autowarefoundation#6809 and minor fix) (autowarefoundation#6965) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modified PR of this #6740
Related links
#6740
Tests performed
see #6740
Notes for reviewers
Interface changes
none
ROS Topic Changes
none
ROS Parameter Changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.