Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): publish initial and goal poses to logs #6918

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented May 2, 2024

Description

Sometimes, while investigating the planning module, we might find a bug that we want to report on GitHub issues.

However, if we didn't echo the initial and goal poses before the simulation, we might miss this information, which could cause difficulties for the ticket's assignee in reproducing the issues.

Since log information is stored in the .ros folder, if we printed the above information, then we could just search back through the log and add the information to the ticket accurately.

Additionally, I personally think that initial and goal poses are essential pieces of information, and it is acceptable to publish them in the terminal.

I believe a lot of man-hours can be saved if we have this information in the terminal log.

After PR

The following information are published.

[component_container_mt-25] [INFO 1714642765.582309670] [planning.mission_planning.mission_planner] publish_pose_log(): initial pose - x: 89154.851562, y: 42421.679688, z: 7.037300:(L93)
[component_container_mt-25] [INFO 1714642765.582357231] [planning.mission_planning.mission_planner] publish_pose_log(): initial orientation - qx: 0.000580, qy: 0.000231, qz: -0.929063, qw: 0.369921:(L96)
[component_container_mt-25] [INFO 1714642765.582366538] [planning.mission_planning.mission_planner] publish_pose_log(): goal pose - x: 89428.851562, y: 43234.484375, z: 5.915613:(L93)
[component_container_mt-25] [INFO 1714642765.582373472] [planning.mission_planning.mission_planner] publish_pose_log(): goal orientation - qx: 0.000000, qy: 0.000000, qz: -0.487659, qw: 0.873034:(L96)

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 2, 2024
@isamu-takagi
Copy link
Contributor

@zulfaqar-azmi-t4
Could you please make it into a function?

@TakaHoribe
Could you check whether the log level is appropriate. I think INFO is fine because it only outputs when setting the route.

@TakaHoribe
Copy link
Contributor

@zulfaqar-azmi-t4 @isamu-takagi

Thank you for your support. Setting initialpose is appropriate as an event notification using the INFO level, following the logging rules https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/console-logging/#rules

Please follow @isamu-takagi -san's comment and his approval.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
Copy link
Contributor Author

zulfaqar-azmi-t4 commented May 2, 2024

@isamu-takagi
It is now refactored as a function in d4af7a8

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 2, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) May 2, 2024 09:55
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 23f99a7 into autowarefoundation:main May 2, 2024
35 of 37 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat-add-logs-for-initial-and-goal branch May 8, 2024 05:24
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…refoundation#6918)

* feat(mission_planner): publish initial and goal poses to logs

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* refactoring to a function

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…refoundation#6918)

* feat(mission_planner): publish initial and goal poses to logs

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* refactoring to a function

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants