-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mission_planner): publish initial and goal poses to logs #6918
feat(mission_planner): publish initial and goal poses to logs #6918
Conversation
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 @TakaHoribe |
@zulfaqar-azmi-t4 @isamu-takagi Thank you for your support. Setting initialpose is appropriate as an event notification using the INFO level, following the logging rules https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/console-logging/#rules Please follow @isamu-takagi -san's comment and his approval. |
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@isamu-takagi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
23f99a7
into
autowarefoundation:main
…refoundation#6918) * feat(mission_planner): publish initial and goal poses to logs Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactoring to a function Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
…refoundation#6918) * feat(mission_planner): publish initial and goal poses to logs Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactoring to a function Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Description
Sometimes, while investigating the planning module, we might find a bug that we want to report on GitHub issues.
However, if we didn't echo the initial and goal poses before the simulation, we might miss this information, which could cause difficulties for the ticket's assignee in reproducing the issues.
Since log information is stored in the .ros folder, if we printed the above information, then we could just search back through the log and add the information to the ticket accurately.
Additionally, I personally think that initial and goal poses are essential pieces of information, and it is acceptable to publish them in the terminal.
I believe a lot of man-hours can be saved if we have this information in the terminal log.
After PR
The following information are published.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.